You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Michael Douglas (JIRA)" <ji...@apache.org> on 2010/04/17 05:12:24 UTC
[jira] Created: (THRIFT-761) Include the symbolic name of a typedef
field in the field metadata [patch]
Include the symbolic name of a typedef field in the field metadata [patch]
--------------------------------------------------------------------------
Key: THRIFT-761
URL: https://issues.apache.org/jira/browse/THRIFT-761
Project: Thrift
Issue Type: New Feature
Components: Compiler (Java)
Affects Versions: 0.2
Environment: All
Reporter: Michael Douglas
Fix For: 0.3
The generator of Java code translates all Thrift typedefs to the appropriate Java types. This means that the Thrift typedef name (aka symbolic name) is being lost during Java code generation.
The typedef symbolic name should be included in the field value meta data so that it is available for those who inspect metadata of their Thrift data structures.
FieldValueMetaData, which is the base class for metadata of field values of all types, already has isStruct(), isContainer() and type and is therefore a natural choice for this.
We should introduce isTypedef() and getTypedefName() into class FieldValueMetaData.
A patch is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (THRIFT-761) Include the symbolic name of a typedef
field in the field metadata [patch]
Posted by "Michael Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Douglas updated THRIFT-761:
-----------------------------------
Issue Type: Improvement (was: New Feature)
> Include the symbolic name of a typedef field in the field metadata [patch]
> --------------------------------------------------------------------------
>
> Key: THRIFT-761
> URL: https://issues.apache.org/jira/browse/THRIFT-761
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Affects Versions: 0.2
> Environment: All
> Reporter: Michael Douglas
> Fix For: 0.3
>
> Attachments: v1-0001-THRIFT-761.-java-Include-typedef-name-in-field-value-metadata.patch
>
>
> The generator of Java code translates all Thrift typedefs to the appropriate Java types. This means that the Thrift typedef name (aka symbolic name) is being lost during Java code generation.
> The typedef symbolic name should be included in the field value meta data so that it is available for those who inspect metadata of their Thrift data structures.
> FieldValueMetaData, which is the base class for metadata of field values of all types, already has isStruct(), isContainer() and type and is therefore a natural choice for this.
> We should introduce isTypedef() and getTypedefName() into class FieldValueMetaData.
> A patch is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (THRIFT-761) Include the symbolic name of a
typedef field in the field metadata [patch]
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury resolved THRIFT-761.
----------------------------------
Assignee: Bryan Duxbury
Resolution: Fixed
I just committed this patch, along with some changes to the tests to verify the new methods work as expected.
> Include the symbolic name of a typedef field in the field metadata [patch]
> --------------------------------------------------------------------------
>
> Key: THRIFT-761
> URL: https://issues.apache.org/jira/browse/THRIFT-761
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (Java)
> Affects Versions: 0.2
> Environment: All
> Reporter: Michael Douglas
> Assignee: Bryan Duxbury
> Fix For: 0.3
>
> Attachments: v1-0001-THRIFT-761.-java-Include-typedef-name-in-field-value-metadata.patch
>
>
> The generator of Java code translates all Thrift typedefs to the appropriate Java types. This means that the Thrift typedef name (aka symbolic name) is being lost during Java code generation.
> The typedef symbolic name should be included in the field value meta data so that it is available for those who inspect metadata of their Thrift data structures.
> FieldValueMetaData, which is the base class for metadata of field values of all types, already has isStruct(), isContainer() and type and is therefore a natural choice for this.
> We should introduce isTypedef() and getTypedefName() into class FieldValueMetaData.
> A patch is attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-761) Include the symbolic name of a typedef
field in the field metadata [patch]
Posted by "Michael Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Douglas updated THRIFT-761:
-----------------------------------
Attachment: v1-0001-THRIFT-761.-java-Include-typedef-name-in-field-value-metadata.patch
> Include the symbolic name of a typedef field in the field metadata [patch]
> --------------------------------------------------------------------------
>
> Key: THRIFT-761
> URL: https://issues.apache.org/jira/browse/THRIFT-761
> Project: Thrift
> Issue Type: New Feature
> Components: Compiler (Java)
> Affects Versions: 0.2
> Environment: All
> Reporter: Michael Douglas
> Fix For: 0.3
>
> Attachments: v1-0001-THRIFT-761.-java-Include-typedef-name-in-field-value-metadata.patch
>
>
> The generator of Java code translates all Thrift typedefs to the appropriate Java types. This means that the Thrift typedef name (aka symbolic name) is being lost during Java code generation.
> The typedef symbolic name should be included in the field value meta data so that it is available for those who inspect metadata of their Thrift data structures.
> FieldValueMetaData, which is the base class for metadata of field values of all types, already has isStruct(), isContainer() and type and is therefore a natural choice for this.
> We should introduce isTypedef() and getTypedefName() into class FieldValueMetaData.
> A patch is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira