You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by ellisonanne <gi...@git.apache.org> on 2016/08/19 15:11:07 UTC
[GitHub] incubator-pirk pull request #73: various minor cleanup items
GitHub user ellisonanne opened a pull request:
https://github.com/apache/incubator-pirk/pull/73
various minor cleanup items
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ellisonanne/incubator-pirk cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/73.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #73
----
commit 74a6f11a1af491cc3b722af3fbb25b9342025b64
Author: ellisonanne <ea...@apache.org>
Date: 2016-07-29T19:45:21Z
Merge pull request #5 from apache/master
up
commit 42f3e8400f810377a4bae06638fc13c0e37707f3
Author: ellisonanne <ea...@apache.org>
Date: 2016-07-31T17:47:15Z
Merge pull request #6 from apache/master
updating fork
commit 887358883d26940845a3486b0dc87cd0cc6c3807
Author: ellisonanne <ea...@apache.org>
Date: 2016-08-01T13:06:35Z
Merge pull request #7 from apache/master
up
commit 2ad5c619084af2517cd135374f93be20410cc45c
Author: ellisonanne <ea...@apache.org>
Date: 2016-08-02T16:22:53Z
Merge pull request #8 from apache/master
updating fork
commit d3c6eeb37a0300ea882c0bb2bcd2939132e7e5cb
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-06T14:23:24Z
Merge pull request #9 from apache/master
updating fork
commit 381f3529f97fa38b7b06be015c7b82471c8b95d5
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-11T13:22:15Z
Merge pull request #10 from apache/master
updating fork
commit 6ab035dd32fc4e3464cfb377ccb3493ecf9a313d
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-12T21:19:23Z
Merge pull request #11 from apache/master
up
commit 47a933f9c1d6c6c80f7b61ba5856a84af8162dca
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-13T12:31:25Z
Merge pull request #12 from apache/master
up
commit 6ba5ed4b3ce4983f1e1aa958b6f55180613fa1a1
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-16T13:30:13Z
Merge pull request #13 from apache/master
updating fork
commit 43818205074456b8e16aa09bb408706bfb9608ed
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-18T17:38:55Z
Merge pull request #14 from apache/master
updating fork
commit 9da10044342663526b3456aa894f204f697a2866
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-19T13:54:59Z
Merge pull request #15 from apache/master
updating fork
commit a3b472b2be9678dad2424bd59b5fcf40d0a786e9
Author: eawilliams <ea...@apache.org>
Date: 2016-08-19T15:10:10Z
cleanup
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #73: various minor cleanup items
Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/73
Yes, I ran 'organize imports' in Eclipse
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #73: various minor cleanup items
Posted by tellison <gi...@git.apache.org>.
Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/73#discussion_r75501927
--- Diff: src/main/java/org/apache/pirk/encryption/PrimeGenerator.java ---
@@ -18,15 +18,15 @@
*/
package org.apache.pirk.encryption;
-import org.apache.pirk.utils.SystemConfiguration;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
import java.math.BigDecimal;
import java.math.BigInteger;
import java.util.HashMap;
import java.util.Random;
+import org.apache.pirk.utils.SystemConfiguration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
--- End diff --
I wonder if we are getting into an IDE commit-fest here, where one IDE thinks the imports should be ordered one way, and another brand of IDE thinks differently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #73: various minor cleanup items
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/73
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #73: various minor cleanup items
Posted by tellison <gi...@git.apache.org>.
Github user tellison commented on the issue:
https://github.com/apache/incubator-pirk/pull/73
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #73: various minor cleanup items
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/73
+1 lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---