You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/08/01 06:22:56 UTC

[GitHub] wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes

wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409462737
 
 
   @brodybits thanks for checking again. The important change is adding `_blank_` to `window.open`, which was not present on my fork's `master` yet (but added to the docs in this PR). I'll create a PR for your test app with all changes needed to make it work.
   
   Also, I'll look into the eslint output.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org