WebDAV NodeTypeProperty 'isInvisibleInAllprop'

[Thomas Müller <th...@day.com>]

Hi,

I believe there is a typo in 'isInvisibleInAllprop'. Should it not be:
isInvisibleInAllProp (uppercase 'P').

Regards,
Thomas

On Tue, Oct 7, 2008 at 3:49 PM,  <re...@apache.org> wrote:
> Author: reschke
> Date: Tue Oct  7 06:49:30 2008
> New Revision: 702481
>
> URL: http://svn.apache.org/viewvc?rev=702481&view=rev
> Log:
> JCR-1790: change "isProtected" to "isInvisibleInAllprop", plus some Javadoc fixes (no functional change)
>
> Modified:
>    jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/nodetype/NodeTypeProperty.java
>    jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/MultiStatusResponse.java
>    jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/property/AbstractDavProperty.java
>    jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/property/DavProperty.java
>    jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/property/HrefProperty.java
>    jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/version/report/ExpandPropertyReport.java
>    jackrabbit/trunk/jackrabbit-webdav/src/main/java/org/apache/jackrabbit/webdav/version/report/SupportedReportSetProperty.java
>
> Modified: jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/nodetype/NodeTypeProperty.java
> URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/nodetype/NodeTypeProperty.java?rev=702481&r1=702480&r2=702481&view=diff
> ==============================================================================
> --- jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/nodetype/NodeTypeProperty.java (original)
> +++ jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/nodetype/NodeTypeProperty.java Tue Oct  7 06:49:30 2008
> @@ -71,7 +71,7 @@
>      * @param property
>      */
>     public NodeTypeProperty(DavProperty property) {
> -        super(property.getName(), property.isProtected());
> +        super(property.getName(), property.isInvisibleInAllprop());

Re: WebDAV NodeTypeProperty 'isInvisibleInAllprop'

[Thomas Müller <th...@day.com>]

Hi,

OK I understand now. Well then let's leave it. There are already many
typos in Jackrabbit.

Regards,
Thomas

Re: WebDAV NodeTypeProperty 'isInvisibleInAllprop'

[Angela Schreiber <an...@day.com>]

>>> Not really. The PROPFIND directive is called "allprop", and I'm just 
>>> using
>>> camel case to put the words "is invisible in allprop" together.
>>
>> Well it's inconsistent with PROPFIND_ALL_PROP

PROPFIND_ALL_PROP was from me. the additional _ isn't julians fault...

> Does it need to be consistent with it? Why?
> If you feel strongly about it, go ahead and change it. All I'm saying is 
> that I choose that particular spelling by purpose.

same for me. thomas, feel free to change either variant
or open an issue...
if you prefer to change PROPFIND_ALL_PROP  to PROPFIND_ALLPROP
(and ev. the related constants), i would like you to deprecate the
old one and add new constants.

thanks
angela

Re: WebDAV NodeTypeProperty 'isInvisibleInAllprop'

[Julian Reschke <ju...@gmx.de>]

Thomas Müller wrote:
> Hi,
> 
>> Not really. The PROPFIND directive is called "allprop", and I'm just using
>> camel case to put the words "is invisible in allprop" together.
> 
> Well it's inconsistent with PROPFIND_ALL_PROP

Does it need to be consistent with it? Why?

If you feel strongly about it, go ahead and change it. All I'm saying is 
that I choose that particular spelling by purpose.

BR, Julian

Re: WebDAV NodeTypeProperty 'isInvisibleInAllprop'

[Thomas Müller <th...@day.com>]

Hi,

> Not really. The PROPFIND directive is called "allprop", and I'm just using
> camel case to put the words "is invisible in allprop" together.

Well it's inconsistent with PROPFIND_ALL_PROP

Regards,
Thomas

Re: WebDAV NodeTypeProperty 'isInvisibleInAllprop'

[Julian Reschke <ju...@gmx.de>]

Thomas Müller wrote:
> Hi,
> 
> I believe there is a typo in 'isInvisibleInAllprop'. Should it not be:
> isInvisibleInAllProp (uppercase 'P').
> 
> Regards,
> Thomas

Not really. The PROPFIND directive is called "allprop", and I'm just 
using camel case to put the words "is invisible in allprop" together.

BR, Julian