You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metamodel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/16 10:48:20 UTC
[jira] [Commented] (METAMODEL-1113) Column naming strategy doesn't
work in csv datastore
[ https://issues.apache.org/jira/browse/METAMODEL-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422581#comment-15422581 ]
ASF GitHub Bot commented on METAMODEL-1113:
-------------------------------------------
GitHub user arjansh opened a pull request:
https://github.com/apache/metamodel/pull/125
Use ColumnNamingStrategy argument in CsvConfiguration constructor
Fixes METAMODEL-1113.
Added unit tests to the different types of datastores which can make use of the ColumnNamingStrategies mechanism and fixed the CsvConfiguration constructor which takes a ColumnNamingStrategy as an arguments but doesn't assign it to its columnNamingStrategy field.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arjansh/metamodel METAMODEL-1113-csv-datastore-column-naming
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #125
----
commit 7d759772bf2d41e0d2f0fb103f163601e4f2ba04
Author: Arjan Seijkens <ar...@humaninference.com>
Date: 2016-08-16T10:46:01Z
Fixes METAMODEL-1113.
Added unit tests to the different types of datastores which can make use of the ColumnNamingStrategies mechanism and fixed the CsvConfiguration constructor which takes a ColumnNamingStrategy as an arguments but doesn't assign it to its columnNamingStrategy field.
----
> Column naming strategy doesn't work in csv datastore
> ----------------------------------------------------
>
> Key: METAMODEL-1113
> URL: https://issues.apache.org/jira/browse/METAMODEL-1113
> Project: Apache MetaModel
> Issue Type: Bug
> Affects Versions: 4.5.4
> Reporter: Arjan Seijkens
>
> METAMODEL-244 introduces the ability to define column names for csv, fixed-width and excel datastores. For csv datastores this doesn't work however, because the CsvConfiguration constructor which takes ColumnNamingStrategy as an argument doesn't actually assign it to its columnNamingStrategy field.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)