You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/11/07 13:06:54 UTC
[GitHub] [openwhisk] steffenrost commented on issue #4709: Extend error
handing in entitlement interface
steffenrost commented on issue #4709: Extend error handing in entitlement interface
URL: https://github.com/apache/openwhisk/pull/4709#issuecomment-551071206
@rabbah - thanks makes sense.
@markusthoemmes - thanks a lot for your review comments and discussion. Regarding your last comment (https://github.com/apache/openwhisk/pull/4709#discussion_r342501051 you are right, by just letting the inner authorization fail using the Future's failure mode we respond with a http response code 500 (internal server error) which is exactly what I wanted to achieve with the change in this pull request as it allows us to differentiate the case where the entitlement returns unauthorized (403).
I'm going to close this pull request because this change can be achieved by only adapting the iam spi entitlement provider implementation in our service. I don't see the need for doing this change in open right now. Sorry for the inconveniences.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services