You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/18 13:55:00 UTC

[jira] [Commented] (ORC-203) Modify the StringStatistics to trim minimum and maximum values

    [ https://issues.apache.org/jira/browse/ORC-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547869#comment-16547869 ] 

ASF GitHub Bot commented on ORC-203:
------------------------------------

GitHub user moresandeep opened a pull request:

    https://github.com/apache/orc/pull/292

    ORC-203 - Update StringStatistics to trim long strings to 1024 characters & record they were trimmed

    This PR adds the functionality described in ORC-203.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/moresandeep/orc ORC-203-Truncate_Max_For_Long_Strings

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #292
    
----
commit dfb488755e0293545b5cfa364ded31b916b7d0f8
Author: Sandeep More <mo...@...>
Date:   2018-07-18T13:31:02Z

    ORC-203 - Update StringStatistics to trim long strings to 1024 characters & record they were trimmed

----


> Modify the StringStatistics to trim minimum and maximum values
> --------------------------------------------------------------
>
>                 Key: ORC-203
>                 URL: https://issues.apache.org/jira/browse/ORC-203
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Owen O'Malley
>            Assignee: Sandeep More
>            Priority: Major
>
> Currently the StringStatistics will record the entire value for minimum or maximum. It creates large protobuf objects and serves very little value. I think we should trim long strings to 1024 characters and record the fact that they were trimmed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)