[GitHub] [lucene-solr] andyvuong commented on a change in pull request #1208: SOLR-13101: Convert nanotime to ms

[GitBox <gi...@apache.org>]

andyvuong commented on a change in pull request #1208: SOLR-13101: Convert nanotime to ms
URL: https://github.com/apache/lucene-solr/pull/1208#discussion_r374839215
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/store/blob/util/BlobStoreUtils.java
 ##########
 @@ -75,6 +76,16 @@ public static String generateMetadataSuffix() {
     return UUID.randomUUID().toString();
   }
 
+  /**
+   * Returns current nano time in millisecond resolution for use in measuring elapsed time.
+   * 
+   * Note: Do not combine this value with currentTimeMillis - currentTimeMillis will return ms relative to epoch
+   * while this method returns ms relative to some arbitrary time
+   */
+  public static long getCurrentNanoTimeInMs() {
 
 Review comment:
   Why not just call it getCurrentTimeMs and let the javadoc make it clear it's not the same as System.currentTimeMillis(), the main reason being it was changed originally to fix ant precommit failures?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org