You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/05 10:35:47 UTC
[GitHub] [superset] ktmud opened a new issue #12963: [Explore] Chart should strip ending semicolon for virtual datasource queries
ktmud opened a new issue #12963:
URL: https://github.com/apache/superset/issues/12963
<img width="921" alt="semicolon" src="https://user-images.githubusercontent.com/335541/107020466-bf0c4480-6757-11eb-93a4-0c065aa97bca.png">
When a virtual datasource has ending semicolon in it's SQL query,
The generated queries for Explore will produce an error:
<img width="540" alt="error" src="https://user-images.githubusercontent.com/335541/107020521-cf242400-6757-11eb-8dd9-e7cf46a86787.png">
Because it didn't strip the semicolon from the original query:
<img width="486" alt="query" src="https://user-images.githubusercontent.com/335541/107020639-f549c400-6757-11eb-8405-07af26e8ce46.png">
The query engine should be smart enough to know semicolon is not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej closed issue #12963: [Explore] Chart should strip ending semicolon for virtual datasource queries
Posted by GitBox <gi...@apache.org>.
zuzana-vej closed issue #12963:
URL: https://github.com/apache/superset/issues/12963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on issue #12963: [Explore] Chart should strip ending semicolon for virtual datasource queries
Posted by GitBox <gi...@apache.org>.
pkdotson commented on issue #12963:
URL: https://github.com/apache/superset/issues/12963#issuecomment-807634549
PR is out: https://github.com/apache/superset/pull/13801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #12963: [Explore] Chart should strip ending semicolon for virtual datasource queries
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #12963:
URL: https://github.com/apache/superset/issues/12963#issuecomment-774218816
I run into this quite often actually. This fix should be very simple, low risk and have good overall effect on UX.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12963: [Explore] Chart should strip ending semicolon for virtual datasource queries
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12963:
URL: https://github.com/apache/superset/issues/12963#issuecomment-774200017
@ktmud would like to have this fixed. how often do you users bump into this error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zuzana-vej commented on issue #12963: [Explore] Chart should strip ending semicolon for virtual datasource queries
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #12963:
URL: https://github.com/apache/superset/issues/12963#issuecomment-824380189
PR was merged to address this (please reopen if that's not the case)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org