You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "swamirishi (via GitHub)" <gi...@apache.org> on 2023/05/02 17:28:38 UTC

[GitHub] [ozone] swamirishi commented on a diff in pull request #4636: HDDS-8505. ReplicationManager: Add configurable global replication limit

swamirishi commented on code in PR #4636:
URL: https://github.com/apache/ozone/pull/4636#discussion_r1182841510


##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/TestUnderReplicatedProcessor.java:
##########
@@ -93,4 +96,40 @@ public void testMessageRequeuedOnException() throws IOException {
     assertEquals(1, queue.underReplicatedQueueSize());
     assertSame(result, queue.dequeueUnderReplicatedContainer());
   }
+
+  @Test
+  public void testMessageNotProcessedIfGlobalLimitReached() throws IOException {
+    AtomicLong inFlightReplications = new AtomicLong(11);

Review Comment:
   Can we have a case to check if replication manager is processing all the requests if inflight replication limit factor is set to 0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org