You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/09 11:17:55 UTC
[GitHub] flink pull request #3854: [hotfix] [rat] Add exclusion for test state snapsh...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3854
[hotfix] [rat] Add exclusion for test state snapshots
Fixes the compilation on Windows by adding rat exclusions for recently added state snapshots.
This must be merged to 1.3 and 1.4.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink hotfix_rat
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3854.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3854
----
commit e4c4fe647f3718ceb3f0c6eef362b1af1ba2dae2
Author: zentol <ch...@apache.org>
Date: 2017-05-09T11:11:33Z
[hotfix] [rat] Add exclusion for test state snapshots
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3854: [hotfix] [rat] Add exclusion for test state snapshots
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3854
I'll look into renaming the files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3854: [hotfix] [rat] Add exclusion for test state snapshots
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3854
Can we use a standardized prefix / suffix for all snapshot files and have one exclusion line in?
The exclusions will grow crazy over time otherwise...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3854: [hotfix] [rat] Add exclusion for test state snapsh...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3854
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3854: [hotfix] [rat] Add exclusion for test state snapshots
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3854
Looks good to me, minus one minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3854: [hotfix] [rat] Add exclusion for test state snapsh...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3854#discussion_r117198127
--- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobSavepointFrom11MigrationITCase.java ---
@@ -129,7 +129,7 @@ public void testCreateSavepointOnFlink11WithRocksDB() throws Exception {
executeAndSavepoint(
env,
- "src/test/resources/stateful-udf-migration-itcase-flink1.1-savepoint-rocksdb",
+ "src/test/resources/stateful-udf-migration-itcase-flink1.1-rocksdbsavepoint",
--- End diff --
I this supposed to be `rocksdb-savepoint`? Otherwise shouldn't be detected by `*-savepoint`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3854: [hotfix] [rat] Add exclusion for test state snapshots
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3854
I've renamed all snapshots/savepoints that I could find. I've added exclusion rules for files ending in `snapshot` and `savepoint`.
rat-plugin passed locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3854: [hotfix] [rat] Add exclusion for test state snapshots
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3854
@tzulitai Nice catch, will fix it while merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3854: [hotfix] [rat] Add exclusion for test state snapshots
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3854
We could do that. These files shouldn't care what their name is, so standardizing them should be rather easy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---