[GitHub] [beam] TheNeuralBit commented on a change in pull request #15836: [BEAM-13099] Use vendored Calcite 1.28.0 in SQL extensions

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #15836:
URL: https://github.com/apache/beam/pull/15836#discussion_r741449798



##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -53,10 +53,12 @@ def hadoopVersions = [
 hadoopVersions.each {kv -> configurations.create("hadoopVersion$kv.key")}
 
 dependencies {
+  // Required for processing Calcite's immutable annotations

Review comment:
       Yeah, to be honest I don't quite understand why this is necessary. Without this we get this error during annotation processing:
   ```
   error: cannot access Value
     class file for org.immutables.value.Value not found
   ```
   
   and then a series of errors due to missing AutoValue-generated classes like:
   ```
   sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/TableName.java:73: error: cannot find symbol
       return new AutoValue_TableName(path == null ? Collections.emptyList() : path, tableName);
                  ^
     symbol:   class AutoValue_TableName
     location: class TableName
   ```
   
   Perhaps this is a bad interaction with another annotation processor?
   
   I'm also inclined to just not worry about this, but I'm a little nervous we'll inflict the same annotation processing issue on our users.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org