[jira] [Commented] (RATIS-49) Add a clean profile to remove shaded source

["Jing Zhao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946052#comment-15946052 ] 

Jing Zhao commented on RATIS-49:
--------------------------------

The patch looks good to me. One minor: currently {{mvn package}} can compile protobuf files and generate shaded files if it finds that "ratis-proto-shaded/src/main/java/" or "ratis-hadoop-shaded/src/main/java/" do not exist. The new {{clean-shade}} only deletes all the files inside but still keeps the directories. Thus if we run "mvn package" immediately after "mvn clean -Pclean-shade", it does not compile (still need "-Dcompile-protobuf").

We can delete the following from the "clean-shade" to fix this.
{code}
+                  <includes>
+                    <include>**/*</include>
+                  </includes>
{code}

> Add a clean profile to remove shaded source
> -------------------------------------------
>
>                 Key: RATIS-49
>                 URL: https://issues.apache.org/jira/browse/RATIS-49
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: r49_20170323b.patch, r49_20170323.patch
>
>
> There is no way to remove the shaded source using mvn.  We have to remove them manually by
> - rm -rf ratis-proto-shaded/src/main/java
> - rm -rf ratis-hadoop-shaded/src/main/java



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)