[GitHub] [dubbo] beiwei30 commented on issue #4650: align ExchangeCodec with DubboCodec

["beiwei30 (GitHub)" <gi...@apache.org>]

I revisit the current impl of ExchangeCodec, and I believe it's fine, for example: 

```java
                ObjectInput in = CodecSupport.deserialize(channel.getUrl(), is, proto);
                if (status == Response.OK) {
                    Object data;
                    if (res.isHeartbeat()) {
                        data = decodeHeartbeatData(channel, in);
                    } else if (res.isEvent()) {
                        data = decodeEventData(channel, in);
                    } else {
                        data = decodeResponseData(channel, in, getRequestData(id));
                    }
                    res.setResult(data);
                } else {
                    res.setErrorMessage(in.readUTF());
                }
```

It is pretty safe to call `CodecSupport.deserialize(channel.getUrl(), is, proto)`  at the first place.

[ Full content available at: https://github.com/apache/dubbo/issues/4650 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org