[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #10836: feat: Stop pending queries when user close dashboard

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #10836:
URL: https://github.com/apache/incubator-superset/pull/10836#discussion_r499938538



##########
File path: superset/charts/api.py
##########
@@ -503,6 +504,50 @@ def data(self) -> Response:
 
         return response
 
+    @expose("/data/stop", methods=["POST"])

Review comment:
       I feel there could be 2 use cases: terminate pending **query(s)** by dashboard_id, or terminate pending **query** by chart id. Currently airbnb has internal API to do 1), but i feel in the future (when the async framework is fully implemented), Superset should be able to do both.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org