You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "shahar1 (via GitHub)" <gi...@apache.org> on 2026/06/17 08:44:33 UTC

[PR] Make prepare-providers-documentation skill rewrite changelog entries for quality [airflow]

shahar1 opened a new pull request, #68663:
URL: https://github.com/apache/airflow/pull/68663

   The AI-driven `prepare-providers-documentation` skill instructed the release manager to copy each commit subject verbatim into the changelog ("Subjects must be the original commit subject ... Don't paraphrase"). In practice that produced low-quality entries that reviewers had to fix by hand during the 2026-06-16 provider wave:
   
   - uninformative wording (`Add missing template_fields to FooOperator`, `fix the ftp tls`),
   - Conventional-Commit / scope prefixes (`fix:`, `docs:`, `refactor:`, `fix(test_wasb.py):`),
   - lowercase starts and non-imperative mood (`made ... to run`, `Renaming ...`),
   - raw dependency/dependabot phrasing instead of the actual version (`Bump aiohttp regarding dependabot warning`),
   - test-file references in user-facing notes,
   - non-user-facing CI / JS build-tooling bumps surfaced in visible sections,
   - providers released with no user-facing change.
   
   This replaces the "don't paraphrase" rule with explicit **entry-wording rules** (capitalized, imperative, no prefixes, specific, dependency bumps pinned to the version read from `pyproject.toml`, Airflow-core compatibility notes), a **"what is not user-facing → hidden block"** section (CI/infra bumps, JS build/dev tooling, comment-only changes, internal renames), and an instruction to **drop a provider to doc-only** (no release) when nothing user-facing remains. It also extends the Phase 3 auto-classify heuristics so CI and build-tooling bumps are classified `skip` up front.
   
   Documentation/tooling-only change to the skill; no runtime Airflow code is affected.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 4.8)
   
   Generated-by: Claude Code (Opus 4.8) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make prepare-providers-documentation skill rewrite changelog entries for quality [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #68663:
URL: https://github.com/apache/airflow/pull/68663#issuecomment-5343508046

   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make prepare-providers-documentation skill rewrite changelog entries for quality [airflow]

Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #68663:
URL: https://github.com/apache/airflow/pull/68663#discussion_r3426845263


##########
.agents/skills/prepare-providers-documentation/SKILL.md:
##########
@@ -215,8 +215,17 @@ Before spawning a sub-agent, apply the same fast heuristics breeze uses
   `providers/<id>/src/airflow/providers/<id>/example_dags/**` → **`s`** (skip).
 - Subject contains `Bump minimum Airflow version` and only `__init__.py` /
   `provider.yaml` changed → **`v`**.
-
-Note these classifications and move on — no sub-agent needed.
+- CI/infra bumps (`[main] Upgrade important CI environment`, workflow-only
+  changes) and JavaScript **build/dev tooling** bumps for a bundled UI
+  (`vite`, `prettier`, `stylelint`, `eslint`, `webpack-*`, `terser-*`,
+  `@types/*`) → **`s`** (skip / not user-facing), even though they touch files
+  outside `tests/`. These belong in the hidden block, never in a visible
+  section.
+
+Note these classifications and move on — no sub-agent needed. Whatever the
+classification, the entry text you ultimately write must follow the
+[entry wording rules](#entry-wording-rules--every-entry-must-read-well-for-users)
+in Phase 4b — rewrite the subject, don't copy it verbatim.

Review Comment:
   I'd add also specific instruction on `Prepare providers release ...` should always be in the hidden part of the change log as this is internal.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make prepare-providers-documentation skill rewrite changelog entries for quality [airflow]

Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #68663:
URL: https://github.com/apache/airflow/pull/68663#discussion_r3426851608


##########
.agents/skills/prepare-providers-documentation/SKILL.md:
##########
@@ -215,8 +215,17 @@ Before spawning a sub-agent, apply the same fast heuristics breeze uses
   `providers/<id>/src/airflow/providers/<id>/example_dags/**` → **`s`** (skip).
 - Subject contains `Bump minimum Airflow version` and only `__init__.py` /
   `provider.yaml` changed → **`v`**.
-
-Note these classifications and move on — no sub-agent needed.
+- CI/infra bumps (`[main] Upgrade important CI environment`, workflow-only

Review Comment:
   I don't know if this is a rule?
   I assume, specifically for fab/edge3 we may update a package due to CI issue but the package is also user facing... we sometimes upgrade due to CVE / security etc...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Make prepare-providers-documentation skill rewrite changelog entries for quality [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #68663: Make prepare-providers-documentation skill rewrite changelog entries for quality
URL: https://github.com/apache/airflow/pull/68663


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org