[GitHub] [shardingsphere] tristaZero commented on issue #7998: "No value specified for parameter" On INSERT

[GitBox <gi...@apache.org>]

tristaZero commented on issue #7998:
URL: https://github.com/apache/shardingsphere/issues/7998#issuecomment-721556550


   @strongduanmu
   
   I appreciated this debug explanation. :)
   I suppose we have to fix this new issue in the next release. 
   Speaking of the solution you mentioned, I agree that we need to count the parameters in `JSON_OBJECT(contact, ?)`. However I am unsure whether we need a new `ExpressionProjectionSegment` containing `Collection<ExpressionSegment>` or add `Collection<ExpressionSegment>` to the existing `ExpressionProjectionSegment`.
   
   For me I prefer a new expressionSegment since `String text` and `subExpressions` could not have a particular value meanwhile. It also looks like the existing `ExpressionProjectionSegment` has no special follow-up handling and just to store the complex parsing content in `text` member.
   
   As @jingshanglu did substantial work on `expression parsing`, let us listen to what he thinks about this one. :)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org