You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/05/08 16:31:26 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request, #6286: Remove dead code for casting dictionaries

alamb opened a new pull request, #6286:
URL: https://github.com/apache/arrow-datafusion/pull/6286

   # Which issue does this PR close?
   
   N/A 
   
   # Rationale for this change
   
   I noticed this while reviewing https://github.com/apache/arrow-datafusion/pull/6269 from @viirya 
   
   https://github.com/apache/arrow-datafusion/issues/3387 has been closed so there is no need for this workaround anylonger
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   
   remove workaround 
   # Are these changes tested?
   covered by existing tests
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #6286: minor: Remove dead code for casting dictionaries

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6286:
URL: https://github.com/apache/arrow-datafusion/pull/6286


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org