You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/02 03:16:06 UTC
[GitHub] [incubator-inlong] leezng opened a new pull request, #4489: [INLONG-4488][Dashboard] Remove useless modules
leezng opened a new pull request, #4489:
URL: https://github.com/apache/incubator-inlong/pull/4489
Fixes #4488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a diff in pull request #4489: [INLONG-4488][Dashboard] Remove useless modules
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #4489:
URL: https://github.com/apache/incubator-inlong/pull/4489#discussion_r887530225
##########
inlong-dashboard/src/configs/menus/index.ts:
##########
@@ -38,10 +38,10 @@ const menus: MenuItemType[] = [
path: '/approvals',
name: i18n.t('configs.menus.ApprovalManagement'),
},
- {
- path: '/datasources',
- name: i18n.t('configs.menus.Datasources'),
- },
+ // {
+ // path: '/datasources',
+ // name: i18n.t('configs.menus.Datasources'),
+ // },
Review Comment:
remove them may be better?
##########
inlong-dashboard/src/configs/routes/index.tsx:
##########
@@ -82,11 +82,11 @@ const routes: RouteProps[] = [
},
],
},
- {
- path: '/dataSources',
- component: () => import('@/pages/DataSources'),
- exact: true,
- },
+ // {
+ // path: '/dataSources',
+ // component: () => import('@/pages/DataSources'),
+ // exact: true,
+ // },
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #4489: [INLONG-4488][Dashboard] Remove useless modules
Posted by GitBox <gi...@apache.org>.
healchow merged PR #4489:
URL: https://github.com/apache/incubator-inlong/pull/4489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] leezng commented on a diff in pull request #4489: [INLONG-4488][Dashboard] Remove useless modules
Posted by GitBox <gi...@apache.org>.
leezng commented on code in PR #4489:
URL: https://github.com/apache/incubator-inlong/pull/4489#discussion_r887592547
##########
inlong-dashboard/src/configs/menus/index.ts:
##########
@@ -38,10 +38,10 @@ const menus: MenuItemType[] = [
path: '/approvals',
name: i18n.t('configs.menus.ApprovalManagement'),
},
- {
- path: '/datasources',
- name: i18n.t('configs.menus.Datasources'),
- },
+ // {
+ // path: '/datasources',
+ // name: i18n.t('configs.menus.Datasources'),
+ // },
Review Comment:
The menu is temporarily hidden, and the code has other functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org