You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "abhioncbr (via GitHub)" <gi...@apache.org> on 2023/03/31 01:54:00 UTC
[GitHub] [pinot] abhioncbr opened a new pull request, #10514: [WIP]: 10513 - Null support in Case/When queries.
abhioncbr opened a new pull request, #10514:
URL: https://github.com/apache/pinot/pull/10514
- Null support in Case/When queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] abhioncbr commented on a diff in pull request #10514: [WIP]: 10513 - Null support in Case/When queries.
Posted by "abhioncbr (via GitHub)" <gi...@apache.org>.
abhioncbr commented on code in PR #10514:
URL: https://github.com/apache/pinot/pull/10514#discussion_r1162208779
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java:
##########
@@ -49,6 +50,10 @@ static RexExpression toRexExpression(RexNode rexNode) {
} else if (rexNode instanceof RexLiteral) {
RexLiteral rexLiteral = ((RexLiteral) rexNode);
FieldSpec.DataType dataType = RelToStageConverter.convertToFieldSpecDataType(rexLiteral.getType());
+ //Added to set the DataType as UNKNOWN
Review Comment:
@walterddr do you think your [PR](https://github.com/apache/pinot/pull/10423) is required here to merge before your change? Right now, it's failing because null is getting set as 'null' literal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] abhioncbr commented on a diff in pull request #10514: [WIP]: 10513 - Null support in Case/When queries.
Posted by "abhioncbr (via GitHub)" <gi...@apache.org>.
abhioncbr commented on code in PR #10514:
URL: https://github.com/apache/pinot/pull/10514#discussion_r1161049540
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java:
##########
@@ -49,6 +50,10 @@ static RexExpression toRexExpression(RexNode rexNode) {
} else if (rexNode instanceof RexLiteral) {
RexLiteral rexLiteral = ((RexLiteral) rexNode);
FieldSpec.DataType dataType = RelToStageConverter.convertToFieldSpecDataType(rexLiteral.getType());
+ //Added to set the DataType as UNKNOWN
Review Comment:
@61yao, After setting the `UNKNOWN` datatype, the value gets set as String `null`., which later fails for the Numeric data type.
I think you have made some changes in a couple of your PR. Do you think, once your PR will be merged this works fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10514: [WIP]: 10513 - Null support in Case/When queries.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10514:
URL: https://github.com/apache/pinot/pull/10514#issuecomment-1491222097
## [Codecov](https://codecov.io/gh/apache/pinot/pull/10514?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10514](https://codecov.io/gh/apache/pinot/pull/10514?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2eff509) into [master](https://codecov.io/gh/apache/pinot/commit/2050376adcb67041972d9707b338373a5e6bc468?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2050376) will **decrease** coverage by `37.89%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #10514 +/- ##
=============================================
- Coverage 70.17% 32.29% -37.89%
+ Complexity 6118 251 -5867
=============================================
Files 2091 2091
Lines 112228 112228
Branches 17088 17088
=============================================
- Hits 78759 36242 -42517
- Misses 27903 72745 +44842
+ Partials 5566 3241 -2325
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `24.64% <ø> (+0.07%)` | :arrow_up: |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `13.95% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1285 files with indirect coverage changes](https://codecov.io/gh/apache/pinot/pull/10514/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] 61yao commented on a diff in pull request #10514: [WIP]: 10513 - Null support in Case/When queries.
Posted by "61yao (via GitHub)" <gi...@apache.org>.
61yao commented on code in PR #10514:
URL: https://github.com/apache/pinot/pull/10514#discussion_r1161179130
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java:
##########
@@ -49,6 +50,10 @@ static RexExpression toRexExpression(RexNode rexNode) {
} else if (rexNode instanceof RexLiteral) {
RexLiteral rexLiteral = ((RexLiteral) rexNode);
FieldSpec.DataType dataType = RelToStageConverter.convertToFieldSpecDataType(rexLiteral.getType());
+ //Added to set the DataType as UNKNOWN
Review Comment:
This is v2 engine code. @walterddr should have a better understanding of this. My code only deals with v1 path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] abhioncbr closed pull request #10514: [WIP]: 10513 - Null support in Case/When queries.
Posted by "abhioncbr (via GitHub)" <gi...@apache.org>.
abhioncbr closed pull request #10514: [WIP]: 10513 - Null support in Case/When queries.
URL: https://github.com/apache/pinot/pull/10514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org