You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Dapeng Sun <da...@intel.com> on 2014/12/25 12:21:37 UTC

Review Request 29419: SENTRY-590 Client factory for generic authorization model

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29419/
-----------------------------------------------------------

Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, shen guoquan, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.


Bugs: SENTRY-590
    https://issues.apache.org/jira/browse/SENTRY-590


Repository: sentry


Description
-------

Base on SENTRY-600: To use clientFactory, **SentryGenericServiceClientFactory** will use for create generic model client.
**SentryGenericServiceClient** need to change to interface, it's a limitation of dynamic proxy.


Diffs
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClient.java 9f4a292 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientFactory.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceIntegration.java 596a8c7 

Diff: https://reviews.apache.org/r/29419/diff/


Testing
-------

Unit Test in local


Thanks,

Dapeng Sun


Re: Review Request 29419: SENTRY-590 Client factory for generic authorization model

Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29419/
-----------------------------------------------------------

(Updated 一月 13, 2015, 7:19 p.m.)


Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, shen guoquan, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.


Changes
-------

Update patch


Bugs: SENTRY-590
    https://issues.apache.org/jira/browse/SENTRY-590


Repository: sentry


Description
-------

Base on SENTRY-600: To use clientFactory, **SentryGenericServiceClientFactory** will use for create generic model client.
**SentryGenericServiceClient** need to change to interface, it's a limitation of dynamic proxy.


Diffs (updated)
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClient.java 9f4a292 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientFactory.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceIntegration.java dfd9f10 

Diff: https://reviews.apache.org/r/29419/diff/


Testing
-------

Unit Test in local


Thanks,

Dapeng Sun