You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by naqashgerard123 <gi...@git.apache.org> on 2018/07/18 06:29:29 UTC
[GitHub] jmeter pull request #393: Jmeter 2.4.x
GitHub user naqashgerard123 opened a pull request:
https://github.com/apache/jmeter/pull/393
Jmeter 2.4.x
## Description
<!--- Provide a general summary of your changes in the Title above -->
<!--- Describe your changes in detail here -->
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, tests ran to see how -->
<!--- your change affects other areas of the code, etc. -->
## Screenshots (if appropriate):
## Types of changes
<!--- What types of changes does your code introduce? Delete as appropriate -->
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/jmeter jmeter-2.4.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/393.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #393
----
commit de4427889d9dfe5b95bb13572c0d6b1652490820
Author: Sebastian Bazley <se...@...>
Date: 2009-08-14T14:38:31Z
Take copy before starting Java 1.5 changes
git-svn-id: https://svn.apache.org/repos/asf/jakarta/jmeter/branches/jmeter-2.4.x@804242 13f79535-47bb-0310-9956-ffa450edef68
commit 75615e9307c20c128ef14da4cadee3d3938d4c0e
Author: Sebastian Bazley <se...@...>
Date: 2011-11-01T21:24:53Z
JMeter TLP move
git-svn-id: https://svn.apache.org/repos/asf/jmeter/branches/jmeter-2.4.x@1196285 13f79535-47bb-0310-9956-ffa450edef68
----
---
Re: [GitHub] jmeter issue #393: Jmeter 2.4.x
Posted by sebb <se...@gmail.com>.
On 18 July 2018 at 16:01, Philippe Mouawad <ph...@gmail.com> wrote:
> On Wednesday, July 18, 2018, sebb <se...@gmail.com> wrote:
>
>> It looks like JMeter PMC don't have karma to close other people's PRs.
>> [That's probably because git is only a mirror.]
>
>
> can’t this be changed by the way ?
Sorry, no idea.
Try asking Infra.
> It would makes things easier for us.
>
>
>>
>> If the originator does not respond, try making a dummy commit with the
>> appropriate 'this fixes #nnn' comment.
>
>
> Thanks, will do
>
>>
>> On 18 July 2018 at 15:41, pmouawad <gi...@git.apache.org> wrote:
>> > Github user pmouawad commented on the issue:
>> >
>> > https://github.com/apache/jmeter/pull/393
>> >
>> > Hello,
>> > What is the purpose of this Pr ?
>> > It looks like it’s empty.
>> >
>> > Can you close it please ?
>> >
>> > Thank you
>> >
>> >
>> > ---
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
Re: [GitHub] jmeter issue #393: Jmeter 2.4.x
Posted by Philippe Mouawad <ph...@gmail.com>.
On Wednesday, July 18, 2018, sebb <se...@gmail.com> wrote:
> It looks like JMeter PMC don't have karma to close other people's PRs.
> [That's probably because git is only a mirror.]
can’t this be changed by the way ?
It would makes things easier for us.
>
> If the originator does not respond, try making a dummy commit with the
> appropriate 'this fixes #nnn' comment.
Thanks, will do
>
> On 18 July 2018 at 15:41, pmouawad <gi...@git.apache.org> wrote:
> > Github user pmouawad commented on the issue:
> >
> > https://github.com/apache/jmeter/pull/393
> >
> > Hello,
> > What is the purpose of this Pr ?
> > It looks like it’s empty.
> >
> > Can you close it please ?
> >
> > Thank you
> >
> >
> > ---
>
--
Cordialement.
Philippe Mouawad.
Re: [GitHub] jmeter issue #393: Jmeter 2.4.x
Posted by sebb <se...@gmail.com>.
It looks like JMeter PMC don't have karma to close other people's PRs.
[That's probably because git is only a mirror.]
If the originator does not respond, try making a dummy commit with the
appropriate 'this fixes #nnn' comment.
On 18 July 2018 at 15:41, pmouawad <gi...@git.apache.org> wrote:
> Github user pmouawad commented on the issue:
>
> https://github.com/apache/jmeter/pull/393
>
> Hello,
> What is the purpose of this Pr ?
> It looks like it’s empty.
>
> Can you close it please ?
>
> Thank you
>
>
> ---
[GitHub] jmeter issue #393: Jmeter 2.4.x
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/393
Hello,
What is the purpose of this Pr ?
It looks like it’s empty.
Can you close it please ?
Thank you
---
[GitHub] jmeter pull request #393: Jmeter 2.4.x
Posted by naqashgerard123 <gi...@git.apache.org>.
Github user naqashgerard123 closed the pull request at:
https://github.com/apache/jmeter/pull/393
---
[GitHub] jmeter pull request #393: Jmeter 2.4.x
Posted by naqashgerard123 <gi...@git.apache.org>.
GitHub user naqashgerard123 reopened a pull request:
https://github.com/apache/jmeter/pull/393
Jmeter 2.4.x
## Description
<!--- Provide a general summary of your changes in the Title above -->
<!--- Describe your changes in detail here -->
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, tests ran to see how -->
<!--- your change affects other areas of the code, etc. -->
## Screenshots (if appropriate):
## Types of changes
<!--- What types of changes does your code introduce? Delete as appropriate -->
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] My code follows the [code style][style-guide] of this project.
- [x] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/jmeter jmeter-2.4.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/393.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #393
----
commit de4427889d9dfe5b95bb13572c0d6b1652490820
Author: Sebastian Bazley <se...@...>
Date: 2009-08-14T14:38:31Z
Take copy before starting Java 1.5 changes
git-svn-id: https://svn.apache.org/repos/asf/jakarta/jmeter/branches/jmeter-2.4.x@804242 13f79535-47bb-0310-9956-ffa450edef68
commit 75615e9307c20c128ef14da4cadee3d3938d4c0e
Author: Sebastian Bazley <se...@...>
Date: 2011-11-01T21:24:53Z
JMeter TLP move
git-svn-id: https://svn.apache.org/repos/asf/jmeter/branches/jmeter-2.4.x@1196285 13f79535-47bb-0310-9956-ffa450edef68
----
---
[GitHub] jmeter pull request #393: Jmeter 2.4.x
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/393
---