You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/14 22:22:41 UTC

[GitHub] [arrow] andygrove commented on a change in pull request #7878: ARROW-9617: [Rust] [DataFusion] Add length of string array

andygrove commented on a change in pull request #7878:
URL: https://github.com/apache/arrow/pull/7878#discussion_r470889218



##########
File path: rust/datafusion/src/execution/context.rs
##########
@@ -450,6 +451,10 @@ impl ExecutionContext {
                 op.clone(),
                 self.create_physical_expr(right, input_schema)?,
             ))),
+            Expr::Length(expr) => Ok(Arc::new(Length::try_new(

Review comment:
       I wonder if we really want to add a new `Expr` specifically for this function when we already have way to register UDFs. It seems like it might be better to treat it just like the other UDFs?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org