You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sr...@apache.org on 2017/04/03 09:09:16 UTC
spark git commit: [MINOR][DOCS] Replace non-breaking space to normal
spaces that breaks rendering markdown
Repository: spark
Updated Branches:
refs/heads/master cff11fd20 -> 364b0db75
[MINOR][DOCS] Replace non-breaking space to normal spaces that breaks rendering markdown
# What changes were proposed in this pull request?
It seems there are several non-breaking spaces were inserted into several `.md`s and they look breaking rendering markdown files.
These are different. For example, this can be checked via `python` as below:
```python
>>> "�"
'\xc2\xa0'
>>> " "
' '
```
_Note that it seems this PR description automatically replaces non-breaking spaces into normal spaces. Please open a `vi` and copy and paste it into `python` to verify this (do not copy the characters here)._
I checked the output below in Sapari and Chrome on Mac OS and, Internal Explorer on Windows 10.
**Before**
**After**
## How was this patch tested?
Manually checking.
These instances were found via
```
grep --include=*.scala --include=*.python --include=*.java --include=*.r --include=*.R --include=*.md --include=*.r -r -I "�" .
```
in Mac OS.
It seems there are several instances more as below:
```
./docs/sql-programming-guide.md: \u2502�� \u251c\u2500\u2500 ...
./docs/sql-programming-guide.md: \u2502�� \u2502
./docs/sql-programming-guide.md: \u2502�� \u251c\u2500\u2500 country=US
./docs/sql-programming-guide.md: \u2502�� \u2502�� \u2514\u2500\u2500 data.parquet
./docs/sql-programming-guide.md: \u2502�� \u251c\u2500\u2500 country=CN
./docs/sql-programming-guide.md: \u2502�� \u2502�� \u2514\u2500\u2500 data.parquet
./docs/sql-programming-guide.md: \u2502�� \u2514\u2500\u2500 ...
./docs/sql-programming-guide.md: �� \u251c\u2500\u2500 ...
./docs/sql-programming-guide.md: �� \u2502
./docs/sql-programming-guide.md: �� \u251c\u2500\u2500 country=US
./docs/sql-programming-guide.md: �� \u2502�� \u2514\u2500\u2500 data.parquet
./docs/sql-programming-guide.md: �� \u251c\u2500\u2500 country=CN
./docs/sql-programming-guide.md: �� \u2502�� \u2514\u2500\u2500 data.parquet
./docs/sql-programming-guide.md: �� \u2514\u2500\u2500 ...
./sql/core/src/test/README.md:\u2502�� \u251c\u2500\u2500 *.avdl # Testing Avro IDL(s)
./sql/core/src/test/README.md:\u2502�� \u2514\u2500\u2500 *.avpr # !! NO TOUCH !! Protocol files generated from Avro IDL(s)
./sql/core/src/test/README.md:\u2502�� \u251c\u2500\u2500 gen-avro.sh # Script used to generate Java code for Avro
./sql/core/src/test/README.md:\u2502�� \u2514\u2500\u2500 gen-thrift.sh # Script used to generate Java code for Thrift
```
These seems generated via `tree` command which inserts non-breaking spaces. They do not look causing any problem for rendering within code blocks and I did not fix it to reduce the overhead to manually replace it when it is overwritten via `tree` command in the future.
Author: hyukjinkwon <gu...@gmail.com>
Closes #17517 from HyukjinKwon/non-breaking-space.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/364b0db7
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/364b0db7
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/364b0db7
Branch: refs/heads/master
Commit: 364b0db75308ddd346b4ab1e032680e8eb4c1753
Parents: cff11fd
Author: hyukjinkwon <gu...@gmail.com>
Authored: Mon Apr 3 10:09:11 2017 +0100
Committer: Sean Owen <so...@cloudera.com>
Committed: Mon Apr 3 10:09:11 2017 +0100
----------------------------------------------------------------------
README.md | 2 +-
docs/building-spark.md | 2 +-
docs/monitoring.md | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/364b0db7/README.md
----------------------------------------------------------------------
diff --git a/README.md b/README.md
index d0eca1d..1e521a7 100644
--- a/README.md
+++ b/README.md
@@ -97,7 +97,7 @@ building for particular Hive and Hive Thriftserver distributions.
Please refer to the [Configuration Guide](http://spark.apache.org/docs/latest/configuration.html)
in the online documentation for an overview on how to configure Spark.
-##�Contributing
+## Contributing
Please review the [Contribution to Spark guide](http://spark.apache.org/contributing.html)
for information on how to get started contributing to the project.
http://git-wip-us.apache.org/repos/asf/spark/blob/364b0db7/docs/building-spark.md
----------------------------------------------------------------------
diff --git a/docs/building-spark.md b/docs/building-spark.md
index 8353b7a..e99b70f 100644
--- a/docs/building-spark.md
+++ b/docs/building-spark.md
@@ -154,7 +154,7 @@ Developers who compile Spark frequently may want to speed up compilation; e.g.,
developers who build with SBT). For more information about how to do this, refer to the
[Useful Developer Tools page](http://spark.apache.org/developer-tools.html#reducing-build-times).
-##�Encrypted Filesystems
+## Encrypted Filesystems
When building on an encrypted filesystem (if your home directory is encrypted, for example), then the Spark build might fail with a "Filename too long" error. As a workaround, add the following in the configuration args of the `scala-maven-plugin` in the project `pom.xml`:
http://git-wip-us.apache.org/repos/asf/spark/blob/364b0db7/docs/monitoring.md
----------------------------------------------------------------------
diff --git a/docs/monitoring.md b/docs/monitoring.md
index 8051952..6cbc666 100644
--- a/docs/monitoring.md
+++ b/docs/monitoring.md
@@ -257,7 +257,7 @@ In the API, an application is referenced by its application ID, `[app-id]`.
When running on YARN, each application may have multiple attempts, but there are attempt IDs
only for applications in cluster mode, not applications in client mode. Applications in YARN cluster mode
can be identified by their `[attempt-id]`. In the API listed below, when running in YARN cluster mode,
-`[app-id]`�will actually be�`[base-app-id]/[attempt-id]`, where `[base-app-id]`�is the YARN application ID.
+`[app-id]` will actually be `[base-app-id]/[attempt-id]`, where `[base-app-id]` is the YARN application ID.
<table class="table">
<tr><th>Endpoint</th><th>Meaning</th></tr>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org