You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "Dan Haywood (JIRA)" <ji...@apache.org> on 2019/01/04 22:37:00 UTC
[jira] [Updated] (ISIS-1806) [WON'T FIX] Reinstate ability to
bookmark action invocations
[ https://issues.apache.org/jira/browse/ISIS-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Haywood updated ISIS-1806:
------------------------------
Summary: [WON'T FIX] Reinstate ability to bookmark action invocations (was: Reinstate ability to bookmark action invocations )
> [WON'T FIX] Reinstate ability to bookmark action invocations
> -------------------------------------------------------------
>
> Key: ISIS-1806
> URL: https://issues.apache.org/jira/browse/ISIS-1806
> Project: Isis
> Issue Type: Bug
> Affects Versions: 1.15.0
> Reporter: Dan Haywood
> Priority: Major
> Fix For: 2.1.0
>
>
> broken in 1.15.0, and commented out in 1.16.0 to avoid user failures.
> The issue is that the BookmarkTreeNode infers a pageType of ACTION_PROMPT, which causes the ActionPromptPage to be rendered. This in turn has a ComponentType of ACTION_PARAMETERS.
> However, the ActionParametersPromptPanelFactory explicitly does not match for actions that take no arguments, and so the only component found is UnknownPanel which - of course - fails to add the correct ActionParametersPanel component.
> This whole area needs reworking ... the ActionParametersPanel now no-longer supports being invoked with no-args or with populated n-args and automatically resolving to the result of the action invocation.
> Instead, will need to move the action execution stuff into the implementation of the AbstractLink that is created within the BookmarkedPagesPanel.
> ~~
> or: maybe we just keep this functionality commented out; is it used anyway ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)