You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/24 12:00:33 UTC

[GitHub] [cloudstack] rhtyd opened a new issue #4726: Check and fix all UI issue from the archived primate repository

rhtyd opened a new issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726


   Triage and address open issues from https://github.com/apache/cloudstack-primate/issues
   And ask authors to port their PRs (if not done already) https://github.com/apache/cloudstack-primate/pulls
   
   ##### ISSUE TYPE
   <!-- Pick one below and delete the rest -->
    * Task
   
   ##### COMPONENT NAME
   <!--
   Categorize the issue, e.g. API, VR, VPN, UI, etc.
   -->
   ~~~
   UI
   ~~~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang edited a comment on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-811714907


   @rhtyd Currently, there is still the PR (https://github.com/apache/cloudstack-primate/pull/898) to consider. I will update it now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang edited a comment on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-800031057


   1. https://github.com/apache/cloudstack-primate/issues/158
      - [x] https://github.com/apache/cloudstack/pull/4762 - When opening a dialog, the first element should be active (with the cursor ready for typing). This avoids extra clicks.
      - [x] https://github.com/apache/cloudstack/pull/4763 - Some dialogs do not have 'Cancel' buttons - for example 'Assign Instance to Another Account'. The 'x' icon on the top right corner is always an option but I think we should be consistent here.
   
   2. https://github.com/apache/cloudstack-primate/issues/462
      - [x] https://github.com/apache/cloudstack/pull/4764 - Create zone form is not aligned in mobile view
      - [x] https://github.com/apache/cloudstack/pull/4765 - Page size changer doesn't show up on mobile mode
      - [x] https://github.com/apache/cloudstack/pull/4766 - Enter to submit a form
      - [x] https://github.com/apache/cloudstack/pull/4769 - While listing domains, on full page reload, it goes back to the root domain
      - [x] ~~https://github.com/apache/cloudstack/pull/4767~~ - Account in user info card doesn't directly go to account but to the account listview
   
   3. https://github.com/apache/cloudstack-primate/issues/465 & https://github.com/apache/cloudstack-primate/issues/615
      - [x] https://github.com/apache/cloudstack/pull/4782 - Refactor async job polling codebase-wide and show multiple async jobs
   
   4. https://github.com/apache/cloudstack-primate/issues/719
      - [x] https://github.com/apache/cloudstack/pull/4811 - Move fetch data to created()
   
   5. https://github.com/apache/cloudstack-primate/issues/743
      - [x] https://github.com/apache/cloudstack/pull/4820 - Edit instance - offer existing Groups
   
   6. Primate PRs:
      - [x] https://github.com/apache/cloudstack/pull/4830 - Support for specifying VR IP in shared networks
      - [x] https://github.com/apache/cloudstack/pull/4831 - Network offering selection - Show display text instead of the name


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang edited a comment on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-800031057


   1. https://github.com/apache/cloudstack-primate/issues/158
      - [x] ~~https://github.com/apache/cloudstack/pull/4762~~ - When opening a dialog, the first element should be active (with the cursor ready for typing). This avoids extra clicks.
      - [x] ~~https://github.com/apache/cloudstack/pull/4763~~ - Some dialogs do not have 'Cancel' buttons - for example 'Assign Instance to Another Account'. The 'x' icon on the top right corner is always an option but I think we should be consistent here.
   
   2. https://github.com/apache/cloudstack-primate/issues/462
      - [x] https://github.com/apache/cloudstack/pull/4764 - Create zone form is not aligned in mobile view
      - [x] ~~https://github.com/apache/cloudstack/pull/4765~~ - Page size changer doesn't show up on mobile mode
      - [x] https://github.com/apache/cloudstack/pull/4766 - Enter to submit a form
      - [x] https://github.com/apache/cloudstack/pull/4769 - While listing domains, on full page reload, it goes back to the root domain
      - [x] ~~https://github.com/apache/cloudstack/pull/4767~~ - Account in user info card doesn't directly go to account but to the account listview
   
   3. https://github.com/apache/cloudstack-primate/issues/465 & https://github.com/apache/cloudstack-primate/issues/615
      - [x] https://github.com/apache/cloudstack/pull/4782 - Refactor async job polling codebase-wide and show multiple async jobs
   
   4. https://github.com/apache/cloudstack-primate/issues/719
      - [x] https://github.com/apache/cloudstack/pull/4811 - Move fetch data to created()
   
   5. https://github.com/apache/cloudstack-primate/issues/743
      - [x] ~~https://github.com/apache/cloudstack/pull/4820~~ - Edit instance - offer existing Groups
   
   6. Primate PRs:
      - [x] ~~https://github.com/apache/cloudstack/pull/4830~~ - Support for specifying VR IP in shared networks
      - [x] ~~https://github.com/apache/cloudstack/pull/4831~~ - Network offering selection - Show display text instead of the name
      - [x] https://github.com/apache/cloudstack/pull/4885 - Multiple Management Server support


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang edited a comment on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-800031057


   1. https://github.com/apache/cloudstack-primate/issues/158
      - [x] https://github.com/apache/cloudstack/pull/4762 - When opening a dialog, the first element should be active (with the cursor ready for typing). This avoids extra clicks.
      - [x] https://github.com/apache/cloudstack/pull/4763 - Some dialogs do not have 'Cancel' buttons - for example 'Assign Instance to Another Account'. The 'x' icon on the top right corner is always an option but I think we should be consistent here.
   
   2. https://github.com/apache/cloudstack-primate/issues/462
      - [x] https://github.com/apache/cloudstack/pull/4764 - Create zone form is not aligned in mobile view
      - [x] https://github.com/apache/cloudstack/pull/4765 - Page size changer doesn't show up on mobile mode
      - [x] https://github.com/apache/cloudstack/pull/4766 - Enter to submit a form
      - [x] https://github.com/apache/cloudstack/pull/4769 - While listing domains, on full page reload, it goes back to the root domain
      - [x] https://github.com/apache/cloudstack/pull/4767 - Account in user info card doesn't directly go to account but to the account listview
   
   3. https://github.com/apache/cloudstack-primate/issues/465 & https://github.com/apache/cloudstack-primate/issues/615
      - [x] https://github.com/apache/cloudstack/pull/4782 - Refactor async job polling codebase-wide and show multiple async jobs
   
   4. https://github.com/apache/cloudstack-primate/issues/719
      - [x] https://github.com/apache/cloudstack/pull/4811 - Move fetch data to created()
   
   5. https://github.com/apache/cloudstack-primate/issues/743
      - [x] https://github.com/apache/cloudstack/pull/4820 - Edit instance - offer existing Groups
   
   6. Primate PRs:
      - [x] https://github.com/apache/cloudstack/pull/4830 - Support for specifying VR IP in shared networks
      - [x] https://github.com/apache/cloudstack/pull/4831 - Network offering selection - Show display text instead of the name


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-800031057


   1. https://github.com/apache/cloudstack-primate/issues/158
      - [x] https://github.com/apache/cloudstack/pull/4762 - When opening a dialog, the first element should be active (with the cursor ready for typing). This avoids extra clicks.
      - [x] https://github.com/apache/cloudstack/pull/4763 - Some dialogs do not have 'Cancel' buttons - for example 'Assign Instance to Another Account'. The 'x' icon on the top right corner is always an option but I think we should be consistent here.
   
   2. https://github.com/apache/cloudstack-primate/issues/462
      - [x] https://github.com/apache/cloudstack/pull/4764 - Create zone form is not aligned in mobile view
      - [x] https://github.com/apache/cloudstack/pull/4765 - Page size changer doesn't show up on mobile mode
      - [x] https://github.com/apache/cloudstack/pull/4766 - Enter to submit a form
      - [x] https://github.com/apache/cloudstack/pull/4769 - While listing domains, on full page reload, it goes back to the root domain
      - [x] https://github.com/apache/cloudstack/pull/4767 - Account in user info card doesn't directly go to account but to the account listview
   
   3. https://github.com/apache/cloudstack-primate/issues/465 & https://github.com/apache/cloudstack-primate/issues/615
      - [x] https://github.com/apache/cloudstack/pull/4782 - Refactor async job polling codebase-wide and show multiple async jobs
   
   4. https://github.com/apache/cloudstack-primate/issues/719
      - [x] https://github.com/apache/cloudstack/pull/4811 - Move fetch data to created()
   
   5. https://github.com/apache/cloudstack-primate/issues/743
      - [x] https://github.com/apache/cloudstack/pull/4820 - Edit instance - offer existing Groups


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang edited a comment on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-811727242


   - [x] https://github.com/apache/cloudstack/pull/4885 - Multiple Management Server support
   - [x] https://github.com/apache/cloudstack/pull/4889 - Integrate Tungsten Fabric


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang edited a comment on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-811714907


   @rhtyd Currently, there is still the PR (https://github.com/apache/cloudstack-primate/pull/898) to consider. I will update it now.
   Also, do you think we need this changed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang edited a comment on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-811727242


   - [x] https://github.com/apache/cloudstack/pull/4885 - Multiple Management Server support


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-811714907


   Currently, there is still the PR (https://github.com/apache/cloudstack-primate/pull/898) to consider. I will update it now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-813259968


   @rhtyd Yes, it is possible to close it
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang edited a comment on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-800031057


   1. https://github.com/apache/cloudstack-primate/issues/158
      - [x] ~~https://github.com/apache/cloudstack/pull/4762~~ - When opening a dialog, the first element should be active (with the cursor ready for typing). This avoids extra clicks.
      - [x] ~~https://github.com/apache/cloudstack/pull/4763~~ - Some dialogs do not have 'Cancel' buttons - for example 'Assign Instance to Another Account'. The 'x' icon on the top right corner is always an option but I think we should be consistent here.
   
   2. https://github.com/apache/cloudstack-primate/issues/462
      - [x] https://github.com/apache/cloudstack/pull/4764 - Create zone form is not aligned in mobile view
      - [x] ~~https://github.com/apache/cloudstack/pull/4765~~ - Page size changer doesn't show up on mobile mode
      - [x] https://github.com/apache/cloudstack/pull/4766 - Enter to submit a form
      - [x] https://github.com/apache/cloudstack/pull/4769 - While listing domains, on full page reload, it goes back to the root domain
      - [x] ~~https://github.com/apache/cloudstack/pull/4767~~ - Account in user info card doesn't directly go to account but to the account listview
   
   3. https://github.com/apache/cloudstack-primate/issues/465 & https://github.com/apache/cloudstack-primate/issues/615
      - [x] https://github.com/apache/cloudstack/pull/4782 - Refactor async job polling codebase-wide and show multiple async jobs
   
   4. https://github.com/apache/cloudstack-primate/issues/719
      - [x] https://github.com/apache/cloudstack/pull/4811 - Move fetch data to created()
   
   5. https://github.com/apache/cloudstack-primate/issues/743
      - [x] ~~https://github.com/apache/cloudstack/pull/4820~~ - Edit instance - offer existing Groups
   
   6. Primate PRs:
      - [x] ~~https://github.com/apache/cloudstack/pull/4830~~ - Support for specifying VR IP in shared networks
      - [x] ~~https://github.com/apache/cloudstack/pull/4831~~ - Network offering selection - Show display text instead of the name


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang edited a comment on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-800031057


   1. https://github.com/apache/cloudstack-primate/issues/158
      - [x] ~~https://github.com/apache/cloudstack/pull/4762~~ - When opening a dialog, the first element should be active (with the cursor ready for typing). This avoids extra clicks.
      - [x] ~~https://github.com/apache/cloudstack/pull/4763~~ - Some dialogs do not have 'Cancel' buttons - for example 'Assign Instance to Another Account'. The 'x' icon on the top right corner is always an option but I think we should be consistent here.
   
   2. https://github.com/apache/cloudstack-primate/issues/462
      - [x] ~~https://github.com/apache/cloudstack/pull/4764~~ - Create zone form is not aligned in mobile view
      - [x] ~~https://github.com/apache/cloudstack/pull/4765~~ - Page size changer doesn't show up on mobile mode
      - [x] https://github.com/apache/cloudstack/pull/4766 - Enter to submit a form
      - [x] https://github.com/apache/cloudstack/pull/4769 - While listing domains, on full page reload, it goes back to the root domain
      - [x] ~~https://github.com/apache/cloudstack/pull/4767~~ - Account in user info card doesn't directly go to account but to the account listview
   
   3. https://github.com/apache/cloudstack-primate/issues/465 & https://github.com/apache/cloudstack-primate/issues/615
      - [x] https://github.com/apache/cloudstack/pull/4782 - Refactor async job polling codebase-wide and show multiple async jobs
   
   4. https://github.com/apache/cloudstack-primate/issues/719
      - [x] https://github.com/apache/cloudstack/pull/4811 - Move fetch data to created()
   
   5. https://github.com/apache/cloudstack-primate/issues/743
      - [x] ~~https://github.com/apache/cloudstack/pull/4820~~ - Edit instance - offer existing Groups
   
   6. Primate PRs:
      - [x] ~~https://github.com/apache/cloudstack/pull/4830~~ - Support for specifying VR IP in shared networks
      - [x] ~~https://github.com/apache/cloudstack/pull/4831~~ - Network offering selection - Show display text instead of the name


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang edited a comment on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-800031057


   1. https://github.com/apache/cloudstack-primate/issues/158
      - [x] https://github.com/apache/cloudstack/pull/4762 - When opening a dialog, the first element should be active (with the cursor ready for typing). This avoids extra clicks.
      - [x] https://github.com/apache/cloudstack/pull/4763 - Some dialogs do not have 'Cancel' buttons - for example 'Assign Instance to Another Account'. The 'x' icon on the top right corner is always an option but I think we should be consistent here.
   
   2. https://github.com/apache/cloudstack-primate/issues/462
      - [x] https://github.com/apache/cloudstack/pull/4764 - Create zone form is not aligned in mobile view
      - [x] https://github.com/apache/cloudstack/pull/4765 - Page size changer doesn't show up on mobile mode
      - [x] https://github.com/apache/cloudstack/pull/4766 - Enter to submit a form
      - [x] https://github.com/apache/cloudstack/pull/4769 - While listing domains, on full page reload, it goes back to the root domain
      - [x] https://github.com/apache/cloudstack/pull/4767 - Account in user info card doesn't directly go to account but to the account listview
   
   3. https://github.com/apache/cloudstack-primate/issues/465 & https://github.com/apache/cloudstack-primate/issues/615
      - [x] https://github.com/apache/cloudstack/pull/4782 - Refactor async job polling codebase-wide and show multiple async jobs
   
   4. https://github.com/apache/cloudstack-primate/issues/719
      - [x] https://github.com/apache/cloudstack/pull/4811 - Move fetch data to created()
   
   5. https://github.com/apache/cloudstack-primate/issues/743
      - [x] https://github.com/apache/cloudstack/pull/4820 - Edit instance - offer existing Groups
   
   6. Primate PRs:
      - [x] https://github.com/apache/cloudstack/pull/4830 - Support for specifying VR IP in shared networks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang edited a comment on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-800031057


   1. https://github.com/apache/cloudstack-primate/issues/158
      - [x] https://github.com/apache/cloudstack/pull/4762 - When opening a dialog, the first element should be active (with the cursor ready for typing). This avoids extra clicks.
      - [x] https://github.com/apache/cloudstack/pull/4763 - Some dialogs do not have 'Cancel' buttons - for example 'Assign Instance to Another Account'. The 'x' icon on the top right corner is always an option but I think we should be consistent here.
   
   2. https://github.com/apache/cloudstack-primate/issues/462
      - [x] https://github.com/apache/cloudstack/pull/4764 - Create zone form is not aligned in mobile view
      - [x] https://github.com/apache/cloudstack/pull/4765 - Page size changer doesn't show up on mobile mode
      - [x] https://github.com/apache/cloudstack/pull/4766 - Enter to submit a form
      - [x] https://github.com/apache/cloudstack/pull/4769 - While listing domains, on full page reload, it goes back to the root domain
      - [x] https://github.com/apache/cloudstack/pull/4767 - Account in user info card doesn't directly go to account but to the account listview
   
   3. https://github.com/apache/cloudstack-primate/issues/465 & https://github.com/apache/cloudstack-primate/issues/615
      - [x] https://github.com/apache/cloudstack/pull/4782 - Refactor async job polling codebase-wide and show multiple async jobs
   
   4. https://github.com/apache/cloudstack-primate/issues/719
      - [x] https://github.com/apache/cloudstack/pull/4811 - Move fetch data to created()
   
   5. https://github.com/apache/cloudstack-primate/issues/743
      - [x] https://github.com/apache/cloudstack/pull/4820 - Edit instance - offer existing Groups
   
   6. Primate PRs:
      - [x] https://github.com/apache/cloudstack/pull/4830 - Support for specifying VR IP in shared networks
      - [ ] https://github.com/apache/cloudstack/pull/4831 - Network offering selection - Show display text instead of the name


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-801713673


   Thanks for the update @utchoang 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-811727242


   [x] https://github.com/apache/cloudstack/pull/4885 - Multiple Management Server support


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-813237025


   @utchoang thanks, the PRs that introduce new features can be raised against master; PRs fixing any bug or introducing (minor) enhanacement can be considered for 4.15 branch. If all the PRs have been raised, can I close this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd closed issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang edited a comment on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-800031057


   1. https://github.com/apache/cloudstack-primate/issues/158
      - [x] https://github.com/apache/cloudstack/pull/4762 - When opening a dialog, the first element should be active (with the cursor ready for typing). This avoids extra clicks.
      - [x] https://github.com/apache/cloudstack/pull/4763 - Some dialogs do not have 'Cancel' buttons - for example 'Assign Instance to Another Account'. The 'x' icon on the top right corner is always an option but I think we should be consistent here.
   
   2. https://github.com/apache/cloudstack-primate/issues/462
      - [x] https://github.com/apache/cloudstack/pull/4764 - Create zone form is not aligned in mobile view
      - [x] https://github.com/apache/cloudstack/pull/4765 - Page size changer doesn't show up on mobile mode
      - [x] https://github.com/apache/cloudstack/pull/4766 - Enter to submit a form
      - [x] https://github.com/apache/cloudstack/pull/4769 - While listing domains, on full page reload, it goes back to the root domain
      - [x] ~~https://github.com/apache/cloudstack/pull/4767~~ - Account in user info card doesn't directly go to account but to the account listview
   
   3. https://github.com/apache/cloudstack-primate/issues/465 & https://github.com/apache/cloudstack-primate/issues/615
      - [x] https://github.com/apache/cloudstack/pull/4782 - Refactor async job polling codebase-wide and show multiple async jobs
   
   4. https://github.com/apache/cloudstack-primate/issues/719
      - [x] https://github.com/apache/cloudstack/pull/4811 - Move fetch data to created()
   
   5. https://github.com/apache/cloudstack-primate/issues/743
      - [x] ~~https://github.com/apache/cloudstack/pull/4820~~ - Edit instance - offer existing Groups
   
   6. Primate PRs:
      - [x] ~~https://github.com/apache/cloudstack/pull/4830~~ - Support for specifying VR IP in shared networks
      - [x] ~~https://github.com/apache/cloudstack/pull/4831~~ - Network offering selection - Show display text instead of the name


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang edited a comment on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-800031057


   1. https://github.com/apache/cloudstack-primate/issues/158
      - [x] https://github.com/apache/cloudstack/pull/4762 - When opening a dialog, the first element should be active (with the cursor ready for typing). This avoids extra clicks.
      - [x] https://github.com/apache/cloudstack/pull/4763 - Some dialogs do not have 'Cancel' buttons - for example 'Assign Instance to Another Account'. The 'x' icon on the top right corner is always an option but I think we should be consistent here.
   
   2. https://github.com/apache/cloudstack-primate/issues/462
      - [x] https://github.com/apache/cloudstack/pull/4764 - Create zone form is not aligned in mobile view
      - [x] https://github.com/apache/cloudstack/pull/4765 - Page size changer doesn't show up on mobile mode
      - [x] https://github.com/apache/cloudstack/pull/4766 - Enter to submit a form
      - [x] https://github.com/apache/cloudstack/pull/4769 - While listing domains, on full page reload, it goes back to the root domain
      - [x] ~~https://github.com/apache/cloudstack/pull/4767~~ - Account in user info card doesn't directly go to account but to the account listview
   
   3. https://github.com/apache/cloudstack-primate/issues/465 & https://github.com/apache/cloudstack-primate/issues/615
      - [x] https://github.com/apache/cloudstack/pull/4782 - Refactor async job polling codebase-wide and show multiple async jobs
   
   4. https://github.com/apache/cloudstack-primate/issues/719
      - [x] https://github.com/apache/cloudstack/pull/4811 - Move fetch data to created()
   
   5. https://github.com/apache/cloudstack-primate/issues/743
      - [x] ~~https://github.com/apache/cloudstack/pull/4820~~ - Edit instance - offer existing Groups
   
   6. Primate PRs:
      - [x] https://github.com/apache/cloudstack/pull/4830 - Support for specifying VR IP in shared networks
      - [x] https://github.com/apache/cloudstack/pull/4831 - Network offering selection - Show display text instead of the name


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang edited a comment on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-800031057


   1. https://github.com/apache/cloudstack-primate/issues/158
      - [x] ~~https://github.com/apache/cloudstack/pull/4762~~ - When opening a dialog, the first element should be active (with the cursor ready for typing). This avoids extra clicks.
      - [x] ~~https://github.com/apache/cloudstack/pull/4763~~ - Some dialogs do not have 'Cancel' buttons - for example 'Assign Instance to Another Account'. The 'x' icon on the top right corner is always an option but I think we should be consistent here.
   
   2. https://github.com/apache/cloudstack-primate/issues/462
      - [x] https://github.com/apache/cloudstack/pull/4764 - Create zone form is not aligned in mobile view
      - [x] ~~https://github.com/apache/cloudstack/pull/4765~~ - Page size changer doesn't show up on mobile mode
      - [x] https://github.com/apache/cloudstack/pull/4766 - Enter to submit a form
      - [x] https://github.com/apache/cloudstack/pull/4769 - While listing domains, on full page reload, it goes back to the root domain
      - [x] ~~https://github.com/apache/cloudstack/pull/4767~~ - Account in user info card doesn't directly go to account but to the account listview
   
   3. https://github.com/apache/cloudstack-primate/issues/465 & https://github.com/apache/cloudstack-primate/issues/615
      - [x] https://github.com/apache/cloudstack/pull/4782 - Refactor async job polling codebase-wide and show multiple async jobs
   
   4. https://github.com/apache/cloudstack-primate/issues/719
      - [x] https://github.com/apache/cloudstack/pull/4811 - Move fetch data to created()
   
   5. https://github.com/apache/cloudstack-primate/issues/743
      - [x] ~~https://github.com/apache/cloudstack/pull/4820~~ - Edit instance - offer existing Groups
   
   6. Primate PRs:
      - [x] ~~https://github.com/apache/cloudstack/pull/4830~~ - Support for specifying VR IP in shared networks
      - [x] ~~https://github.com/apache/cloudstack/pull/4831~~ - Network offering selection - Show display text instead of the name


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on issue #4726: Check and fix all UI issue from the archived primate repository

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4726:
URL: https://github.com/apache/cloudstack/issues/4726#issuecomment-811707754


   @utchoang are all the issues fixed/raised, can this ticket be closed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org