You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Vera Volynets (JIRA)" <ji...@apache.org> on 2007/02/07 17:17:05 UTC

[jira] Created: (HARMONY-3133) [drlvm][classloader] Add check of feild and method for classfile of version lower than 49

[drlvm][classloader] Add check of feild and method for classfile of version lower than 49
-----------------------------------------------------------------------------------------

                 Key: HARMONY-3133
                 URL: https://issues.apache.org/jira/browse/HARMONY-3133
             Project: Harmony
          Issue Type: Improvement
          Components: DRLVM
            Reporter: Vera Volynets


Accordingly to specification of 1.4 Java field and method names are identifiers, see 4.5, 4.6, 2.2.
That means that name should consist of Unicode letters and digits, first must be letter.
To check that letter is Unicode, I use icuuc module.
Changes in patch:
1) link icuuc library, changes in .xml files and make files
2) changes in Class_File_Loader.cpp. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3133) [drlvm][classloader] Add check of field and method names for classfile of version lower than 49

Posted by "Vera Volynets (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vera Volynets updated HARMONY-3133:
-----------------------------------

    Summary: [drlvm][classloader] Add check of field and method names for classfile of version lower than 49  (was: [drlvm][classloader] Add check of feild and method for classfile of version lower than 49)

> [drlvm][classloader] Add check of field and method names for classfile of version lower than 49
> -----------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3133
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3133
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Vera Volynets
>         Attachments: icu_use_classlib.patch, icu_use_vm.patch
>
>
> Accordingly to specification of 1.4 Java field and method names are identifiers, see 4.5, 4.6, 2.2.
> That means that name should consist of Unicode letters and digits, first must be letter.
> To check that letter is Unicode, I use icuuc module.
> Changes in patch:
> 1) link icuuc library, changes in .xml files and make files
> 2) changes in Class_File_Loader.cpp. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3133) [drlvm][classloader] Add check of field and method names for classfile of version lower than 49

Posted by "Vera Petrashkova (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471586 ] 

Vera Petrashkova commented on HARMONY-3133:
-------------------------------------------

VM throws ClassFormatError on incorrect classes with wrong field/method names when -Xverify oprion is used

> [drlvm][classloader] Add check of field and method names for classfile of version lower than 49
> -----------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3133
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3133
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Vera Volynets
>         Assigned To: Gregory Shimansky
>         Attachments: icu_use_classlib.patch, icu_use_vm.patch, run_cuinit_tests.patch
>
>
> Accordingly to specification of 1.4 Java field and method names are identifiers, see 4.5, 4.6, 2.2.
> That means that name should consist of Unicode letters and digits, first must be letter.
> To check that letter is Unicode, I use icuuc module.
> Changes in patch:
> 1) link icuuc library, changes in .xml files and make files
> 2) changes in Class_File_Loader.cpp. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-3133) [drlvm][classloader] Add check of field and method names for classfile of version lower than 49

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky resolved HARMONY-3133.
----------------------------------------

    Resolution: Fixed
      Assignee: Gregory Shimansky

Patch applied at 504950. Please check that it was applied as expected.

I've had to add a symlink to libicudata.so in vmcode.xml file just like you've done to libicuuc.so.

> [drlvm][classloader] Add check of field and method names for classfile of version lower than 49
> -----------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3133
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3133
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Vera Volynets
>         Assigned To: Gregory Shimansky
>         Attachments: icu_use_classlib.patch, icu_use_vm.patch, run_cuinit_tests.patch
>
>
> Accordingly to specification of 1.4 Java field and method names are identifiers, see 4.5, 4.6, 2.2.
> That means that name should consist of Unicode letters and digits, first must be letter.
> To check that letter is Unicode, I use icuuc module.
> Changes in patch:
> 1) link icuuc library, changes in .xml files and make files
> 2) changes in Class_File_Loader.cpp. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3133) [drlvm][classloader] Add check of feild and method for classfile of version lower than 49

Posted by "Vera Volynets (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vera Volynets updated HARMONY-3133:
-----------------------------------

    Attachment: icu_use_classlib.patch

first patch

> [drlvm][classloader] Add check of feild and method for classfile of version lower than 49
> -----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3133
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3133
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Vera Volynets
>         Attachments: icu_use_classlib.patch
>
>
> Accordingly to specification of 1.4 Java field and method names are identifiers, see 4.5, 4.6, 2.2.
> That means that name should consist of Unicode letters and digits, first must be letter.
> To check that letter is Unicode, I use icuuc module.
> Changes in patch:
> 1) link icuuc library, changes in .xml files and make files
> 2) changes in Class_File_Loader.cpp. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3133) [drlvm][classloader] Add check of feild and method for classfile of version lower than 49

Posted by "Vera Volynets (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vera Volynets updated HARMONY-3133:
-----------------------------------

    Attachment: icu_use_vm.patch

second patch

> [drlvm][classloader] Add check of feild and method for classfile of version lower than 49
> -----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3133
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3133
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Vera Volynets
>         Attachments: icu_use_classlib.patch, icu_use_vm.patch
>
>
> Accordingly to specification of 1.4 Java field and method names are identifiers, see 4.5, 4.6, 2.2.
> That means that name should consist of Unicode letters and digits, first must be letter.
> To check that letter is Unicode, I use icuuc module.
> Changes in patch:
> 1) link icuuc library, changes in .xml files and make files
> 2) changes in Class_File_Loader.cpp. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-3133) [drlvm][classloader] Add check of field and method names for classfile of version lower than 49

Posted by "Vera Volynets (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vera Volynets updated HARMONY-3133:
-----------------------------------

    Attachment: run_cuinit_tests.patch

Gregory, I've fixed the problem, see patch attached.

> [drlvm][classloader] Add check of field and method names for classfile of version lower than 49
> -----------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3133
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3133
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Vera Volynets
>         Attachments: icu_use_classlib.patch, icu_use_vm.patch, run_cuinit_tests.patch
>
>
> Accordingly to specification of 1.4 Java field and method names are identifiers, see 4.5, 4.6, 2.2.
> That means that name should consist of Unicode letters and digits, first must be letter.
> To check that letter is Unicode, I use icuuc module.
> Changes in patch:
> 1) link icuuc library, changes in .xml files and make files
> 2) changes in Class_File_Loader.cpp. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-3133) [drlvm][classloader] Add check of field and method names for classfile of version lower than 49

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky closed HARMONY-3133.
--------------------------------------


VERIFIED

> [drlvm][classloader] Add check of field and method names for classfile of version lower than 49
> -----------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3133
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3133
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Vera Volynets
>         Assigned To: Gregory Shimansky
>         Attachments: icu_use_classlib.patch, icu_use_vm.patch, run_cuinit_tests.patch
>
>
> Accordingly to specification of 1.4 Java field and method names are identifiers, see 4.5, 4.6, 2.2.
> That means that name should consist of Unicode letters and digits, first must be letter.
> To check that letter is Unicode, I use icuuc module.
> Changes in patch:
> 1) link icuuc library, changes in .xml files and make files
> 2) changes in Class_File_Loader.cpp. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-3133) [drlvm][classloader] Add check of field and method names for classfile of version lower than 49

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-3133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471340 ] 

Gregory Shimansky commented on HARMONY-3133:
--------------------------------------------

I've tried this patch and it looks like cunit tests on Linux don't work. They fail to link with libharmonyvm.so with the following error message:

     [echo] ## Linking C unit test: test_java_attrs
       [cc] 0 total files to be compiled.
       [cc] Starting link
       [cc] /usr/lib64/gcc-lib/x86_64-suse-linux/3.3.3/../../../../x86_64-suse-linux/bin/ld: warning: libicuuc.so.34, needed by /nfs/ims/proj/drl/mrt1/users/gregory/em64t/trunk/working_vm/build/lnx_em64t_gcc_debug/semis/vm/vmcore/_bin/libharmonyvm.so, not found (try using -rpath or -rpath-link)
       [cc] /nfs/ims/proj/drl/mrt1/users/gregory/em64t/trunk/working_vm/build/lnx_em64t_gcc_debug/semis/vm/vmcore/_bin/libharmonyvm.so: undefined reference to `u_isalpha_3_4'
       [cc] /nfs/ims/proj/drl/mrt1/users/gregory/em64t/trunk/working_vm/build/lnx_em64t_gcc_debug/semis/vm/vmcore/_bin/libharmonyvm.so: undefined reference to `u_isalnum_3_4'
       [cc] collect2: ld returned 1 exit status


> [drlvm][classloader] Add check of field and method names for classfile of version lower than 49
> -----------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-3133
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3133
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Vera Volynets
>         Attachments: icu_use_classlib.patch, icu_use_vm.patch
>
>
> Accordingly to specification of 1.4 Java field and method names are identifiers, see 4.5, 4.6, 2.2.
> That means that name should consist of Unicode letters and digits, first must be letter.
> To check that letter is Unicode, I use icuuc module.
> Changes in patch:
> 1) link icuuc library, changes in .xml files and make files
> 2) changes in Class_File_Loader.cpp. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.