You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "dipankr (via GitHub)" <gi...@apache.org> on 2023/06/25 17:37:47 UTC
[PR] [ISSUE #4107] made fields final (eventmesh)
dipankr opened a new pull request, #4155:
URL: https://github.com/apache/eventmesh/pull/4155
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #4107 #4106 #4104 #4103.
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
the changes are pretty straightforward and makes sense
### Modifications
*Describe the modifications you've done.*
made fields final
also, some cleanup suggested by IDE
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4107] made fields final (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4155:
URL: https://github.com/apache/eventmesh/pull/4155#issuecomment-1606430765
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4155?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4155](https://app.codecov.io/gh/apache/eventmesh/pull/4155?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e2ecff3) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/991cbdae829fcc15698654ca2c737575141f5286?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (991cbda) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head e2ecff3 differs from pull request most recent head e3011e3. Consider uploading reports for the commit e3011e3 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4155 +/- ##
============================================
- Coverage 16.93% 16.91% -0.02%
Complexity 1410 1410
============================================
Files 588 588
Lines 25739 25737 -2
Branches 2387 2373 -14
============================================
- Hits 4358 4353 -5
- Misses 20946 20950 +4
+ Partials 435 434 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/4155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../tcp/client/session/push/DownStreamMsgContext.java](https://app.codecov.io/gh/apache/eventmesh/pull/4155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3B1c2gvRG93blN0cmVhbU1zZ0NvbnRleHQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../protocol/tcp/client/session/push/PushContext.java](https://app.codecov.io/gh/apache/eventmesh/pull/4155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3B1c2gvUHVzaENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...cp/client/session/send/EventMeshTcpSendResult.java](https://app.codecov.io/gh/apache/eventmesh/pull/4155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3NlbmQvRXZlbnRNZXNoVGNwU2VuZFJlc3VsdC5qYXZh) | `0.00% <ø> (ø)` | |
| [...rotocol/tcp/client/session/send/SessionSender.java](https://app.codecov.io/gh/apache/eventmesh/pull/4155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3NlbmQvU2Vzc2lvblNlbmRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4155/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4107] made fields final (eventmesh)
Posted by "dipankr (via GitHub)" <gi...@apache.org>.
dipankr closed pull request #4155: [ISSUE #4107] made fields final
URL: https://github.com/apache/eventmesh/pull/4155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4107] made fields final (eventmesh)
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on code in PR #4155:
URL: https://github.com/apache/eventmesh/pull/4155#discussion_r1241477940
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/send/SessionSender.java:
##########
@@ -139,6 +139,7 @@ public EventMeshTcpSendResult send(Header header, CloudEvent event, SendCallback
Objects.requireNonNull(session.getClientGroupWrapper().get())
.send(upStreamMsgContext, sendCallback);
} finally {
+ session.getSender().getFailMsgCount().incrementAndGet();
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4107] made fields final (eventmesh)
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #4155:
URL: https://github.com/apache/eventmesh/pull/4155#discussion_r1241705005
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/send/SessionSender.java:
##########
@@ -139,6 +139,7 @@ public EventMeshTcpSendResult send(Header header, CloudEvent event, SendCallback
Objects.requireNonNull(session.getClientGroupWrapper().get())
.send(upStreamMsgContext, sendCallback);
} finally {
+ session.getSender().getFailMsgCount().incrementAndGet();
Review Comment:
@dipankr what needs to be modified is here:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/send/UpStreamMsgContext.java line 142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4107] made fields final (eventmesh)
Posted by "dipankr (via GitHub)" <gi...@apache.org>.
dipankr commented on code in PR #4155:
URL: https://github.com/apache/eventmesh/pull/4155#discussion_r1241749560
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/send/SessionSender.java:
##########
@@ -139,6 +139,7 @@ public EventMeshTcpSendResult send(Header header, CloudEvent event, SendCallback
Objects.requireNonNull(session.getClientGroupWrapper().get())
.send(upStreamMsgContext, sendCallback);
} finally {
+ session.getSender().getFailMsgCount().incrementAndGet();
Review Comment:
updated the PR, moved the line to correct class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4107] made fields final (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on code in PR #4155:
URL: https://github.com/apache/eventmesh/pull/4155#discussion_r1241374244
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/send/SessionSender.java:
##########
@@ -139,6 +139,7 @@ public EventMeshTcpSendResult send(Header header, CloudEvent event, SendCallback
Objects.requireNonNull(session.getClientGroupWrapper().get())
.send(upStreamMsgContext, sendCallback);
} finally {
+ session.getSender().getFailMsgCount().incrementAndGet();
Review Comment:
why you add failMsgCount at here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4107] made fields final (eventmesh)
Posted by "dipankr (via GitHub)" <gi...@apache.org>.
dipankr commented on code in PR #4155:
URL: https://github.com/apache/eventmesh/pull/4155#discussion_r1241478496
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/send/SessionSender.java:
##########
@@ -139,6 +139,7 @@ public EventMeshTcpSendResult send(Header header, CloudEvent event, SendCallback
Objects.requireNonNull(session.getClientGroupWrapper().get())
.send(upStreamMsgContext, sendCallback);
} finally {
+ session.getSender().getFailMsgCount().incrementAndGet();
Review Comment:
> why you add failMsgCount at here?
In #4103, in fixes section, it was mentioned to add this line at line 142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4107] made fields final (eventmesh)
Posted by "dipankr (via GitHub)" <gi...@apache.org>.
dipankr commented on PR #4155:
URL: https://github.com/apache/eventmesh/pull/4155#issuecomment-1607688301
https://github.com/apache/eventmesh/pull/4158 -- updated PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org