You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2014/11/22 02:35:27 UTC
Review Request 28361: Extract thrift into an API subproject.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
Bugs: AURORA-925
https://issues.apache.org/jira/browse/AURORA-925
Repository: aurora
Description
-------
Extract thrift generation into an api subproject.
Diffs
-----
.gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
build-support/thrift/thriftw PRE-CREATION
build.gradle 6894ceb7055c0491dce1c869fad0371d432f6540
buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
settings.gradle PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
src/main/thrift/org/apache/aurora/gen/BUILD
src/main/thrift/org/apache/aurora/gen/api.thrift
src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
src/main/thrift/org/apache/aurora/gen/storage.thrift
src/main/thrift/org/apache/aurora/gen/test.thrift
src/main/thrift/org/apache/thermos/BUILD
src/main/thrift/org/apache/thermos/thermos_internal.thrift
src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
Diff: https://reviews.apache.org/r/28361/diff/
Testing
-------
./gradlew -Pq build
./pants src/test/python:all
Thanks,
Kevin Sweeney
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62942
-----------------------------------------------------------
buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy
<https://reviews.apache.org/r/28361/#comment105128>
Just realized I need to define this in an afterEvaluate block for these properties to be correctly readable.
- Kevin Sweeney
On Nov. 24, 2014, 10:37 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2014, 10:37 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 7b35dedb19143b27955c12c4df94ba98ff5f6608
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle 3e9cbfe6e6836f70fb9164f80973f3ebb813ef98
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/resources/scheduler/assets/scheduler/index.html f4ca07166aee21b8e6b7d3da82454e1b9b132f59
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62941
-----------------------------------------------------------
Master (9514a63) is red with this patch.
./build-support/jenkins/build.sh
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_builder.py", line 43, in build
debug=debug).run()
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 88, in run
rv = self._run_tests([target], stdout, stderr)
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 316, in _run_tests
with self._test_runner(targets, stdout, stderr) as (pex, test_args):
File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
return self.gen.next()
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 295, in _test_runner
builder = chroot.dump()
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_chroot.py", line 191, in dump
conn_timeout=self._conn_timeout)
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/resolver.py", line 100, in resolve_multi
platform=platform)
File "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pex/resolver.py", line 101, in resolve
raise Unsatisfiable('Cannot satisfy requirements: %s' % requirement_set[requirement.key])
Unsatisfiable: Cannot satisfy requirements: [PythonRequirement(unittest2)]
Usage:
pants build (options) [spec] (build args)
pants build (options) [spec]... -- (build args)
Options:
--version show program's version number and exit
--no-pantsrc Specifies that pantsrc files should be ignored.
--log-exit Log an exit message on success or failure.
-t CONN_TIMEOUT, --timeout=CONN_TIMEOUT
Number of seconds to wait for http connections.
-i INTERPRETERS, --interpreter=INTERPRETERS
Constrain what Python interpreters to use. Uses
Requirement format from pkg_resources, e.g.
'CPython>=2.6,<3' or 'PyPy'. By default, no
constraints are used. Multiple constraints may be
added. They will be ORed together.
-v, --verbose Show verbose output.
-f, --fast Run tests in a single chroot.
Builds the specified Python target(s). Use ./pants goal for JVM and other
targets.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 25, 2014, 6:37 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 6:37 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 7b35dedb19143b27955c12c4df94ba98ff5f6608
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle 3e9cbfe6e6836f70fb9164f80973f3ebb813ef98
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/resources/scheduler/assets/scheduler/index.html f4ca07166aee21b8e6b7d3da82454e1b9b132f59
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review63025
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Nov. 25, 2014, 6:37 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 6:37 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 7b35dedb19143b27955c12c4df94ba98ff5f6608
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle 3e9cbfe6e6836f70fb9164f80973f3ebb813ef98
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/resources/scheduler/assets/scheduler/index.html f4ca07166aee21b8e6b7d3da82454e1b9b132f59
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review63030
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Nov. 25, 2014, 7:39 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 7:39 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 7b35dedb19143b27955c12c4df94ba98ff5f6608
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle 3e9cbfe6e6836f70fb9164f80973f3ebb813ef98
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/resources/scheduler/assets/scheduler/index.html f4ca07166aee21b8e6b7d3da82454e1b9b132f59
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review63029
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Nov. 25, 2014, 7:39 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 7:39 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 7b35dedb19143b27955c12c4df94ba98ff5f6608
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle 3e9cbfe6e6836f70fb9164f80973f3ebb813ef98
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/resources/scheduler/assets/scheduler/index.html f4ca07166aee21b8e6b7d3da82454e1b9b132f59
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review63058
-----------------------------------------------------------
Master (5e80581) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 25, 2014, 8:22 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 8:22 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 7b35dedb19143b27955c12c4df94ba98ff5f6608
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle 3e9cbfe6e6836f70fb9164f80973f3ebb813ef98
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/resources/scheduler/assets/scheduler/index.html f4ca07166aee21b8e6b7d3da82454e1b9b132f59
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review63035
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Nov. 25, 2014, 12:22 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 12:22 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 7b35dedb19143b27955c12c4df94ba98ff5f6608
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle 3e9cbfe6e6836f70fb9164f80973f3ebb813ef98
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/resources/scheduler/assets/scheduler/index.html f4ca07166aee21b8e6b7d3da82454e1b9b132f59
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/
-----------------------------------------------------------
(Updated Nov. 25, 2014, 12:22 p.m.)
Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
Changes
-------
My feedback (make task input evaluation lazier).
Bugs: AURORA-925
https://issues.apache.org/jira/browse/AURORA-925
Repository: aurora
Description
-------
Extract thrift generation into an api subproject.
Diffs (updated)
-----
.gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
build-support/thrift/thriftw PRE-CREATION
build.gradle 7b35dedb19143b27955c12c4df94ba98ff5f6608
buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
settings.gradle 3e9cbfe6e6836f70fb9164f80973f3ebb813ef98
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
src/main/resources/scheduler/assets/scheduler/index.html f4ca07166aee21b8e6b7d3da82454e1b9b132f59
src/main/thrift/org/apache/aurora/gen/BUILD
src/main/thrift/org/apache/aurora/gen/api.thrift
src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
src/main/thrift/org/apache/aurora/gen/storage.thrift
src/main/thrift/org/apache/aurora/gen/test.thrift
src/main/thrift/org/apache/thermos/BUILD
src/main/thrift/org/apache/thermos/thermos_internal.thrift
src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
Diff: https://reviews.apache.org/r/28361/diff/
Testing
-------
./gradlew -Pq build
./pants src/test/python:all
Thanks,
Kevin Sweeney
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/
-----------------------------------------------------------
(Updated Nov. 25, 2014, 11:39 a.m.)
Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
Changes
-------
License headers, Maxim's feedback.
Bugs: AURORA-925
https://issues.apache.org/jira/browse/AURORA-925
Repository: aurora
Description
-------
Extract thrift generation into an api subproject.
Diffs (updated)
-----
.gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
build-support/thrift/thriftw PRE-CREATION
build.gradle 7b35dedb19143b27955c12c4df94ba98ff5f6608
buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
settings.gradle 3e9cbfe6e6836f70fb9164f80973f3ebb813ef98
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
src/main/resources/scheduler/assets/scheduler/index.html f4ca07166aee21b8e6b7d3da82454e1b9b132f59
src/main/thrift/org/apache/aurora/gen/BUILD
src/main/thrift/org/apache/aurora/gen/api.thrift
src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
src/main/thrift/org/apache/aurora/gen/storage.thrift
src/main/thrift/org/apache/aurora/gen/test.thrift
src/main/thrift/org/apache/thermos/BUILD
src/main/thrift/org/apache/thermos/thermos_internal.thrift
src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
Diff: https://reviews.apache.org/r/28361/diff/
Testing
-------
./gradlew -Pq build
./pants src/test/python:all
Thanks,
Kevin Sweeney
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/
-----------------------------------------------------------
(Updated Nov. 24, 2014, 10:37 p.m.)
Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
Changes
-------
Updated with feedback (still missing license headers).
Bugs: AURORA-925
https://issues.apache.org/jira/browse/AURORA-925
Repository: aurora
Description
-------
Extract thrift generation into an api subproject.
Diffs (updated)
-----
.gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
build-support/thrift/thriftw PRE-CREATION
build.gradle 7b35dedb19143b27955c12c4df94ba98ff5f6608
buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
settings.gradle 3e9cbfe6e6836f70fb9164f80973f3ebb813ef98
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
src/main/resources/scheduler/assets/scheduler/index.html f4ca07166aee21b8e6b7d3da82454e1b9b132f59
src/main/thrift/org/apache/aurora/gen/BUILD
src/main/thrift/org/apache/aurora/gen/api.thrift
src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
src/main/thrift/org/apache/aurora/gen/storage.thrift
src/main/thrift/org/apache/aurora/gen/test.thrift
src/main/thrift/org/apache/thermos/BUILD
src/main/thrift/org/apache/thermos/thermos_internal.thrift
src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
Diff: https://reviews.apache.org/r/28361/diff/
Testing
-------
./gradlew -Pq build
./pants src/test/python:all
Thanks,
Kevin Sweeney
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Kevin Sweeney <ke...@apache.org>.
> On Nov. 24, 2014, 11:25 a.m., Joshua Cohen wrote:
> > build.gradle, line 182
> > <https://reviews.apache.org/r/28361/diff/1/?file=772953#file772953line182>
> >
> > LocalSchedulerMain seems broken in general, but I recall that we needed to mark these directories as source directories so that running the scheduler from IntelliJ worked properly.
>
> Bill Farner wrote:
> Can you try this again after having enabled annotation processors in intellij?
>
> Joshua Cohen wrote:
> This fails via ./gradlew run as well as IntelliJ. Unrelated to my annotation processors getting unchecked alas.
Figured it out - scheduler/ was an ambiguous classpath location, existing under both test and main. giving a more concrete path fixes this.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62825
-----------------------------------------------------------
On Nov. 21, 2014, 5:35 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 5:35 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 6894ceb7055c0491dce1c869fad0371d432f6540
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Bill Farner <wf...@apache.org>.
> On Nov. 24, 2014, 7:25 p.m., Joshua Cohen wrote:
> > build.gradle, line 182
> > <https://reviews.apache.org/r/28361/diff/1/?file=772953#file772953line182>
> >
> > LocalSchedulerMain seems broken in general, but I recall that we needed to mark these directories as source directories so that running the scheduler from IntelliJ worked properly.
Can you try this again after having enabled annotation processors in intellij?
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62825
-----------------------------------------------------------
On Nov. 22, 2014, 1:35 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2014, 1:35 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 6894ceb7055c0491dce1c869fad0371d432f6540
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Joshua Cohen <jc...@twopensource.com>.
> On Nov. 24, 2014, 7:25 p.m., Joshua Cohen wrote:
> > build.gradle, line 182
> > <https://reviews.apache.org/r/28361/diff/1/?file=772953#file772953line182>
> >
> > LocalSchedulerMain seems broken in general, but I recall that we needed to mark these directories as source directories so that running the scheduler from IntelliJ worked properly.
>
> Bill Farner wrote:
> Can you try this again after having enabled annotation processors in intellij?
This fails via ./gradlew run as well as IntelliJ. Unrelated to my annotation processors getting unchecked alas.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62825
-----------------------------------------------------------
On Nov. 22, 2014, 1:35 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2014, 1:35 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 6894ceb7055c0491dce1c869fad0371d432f6540
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62825
-----------------------------------------------------------
./gradlew run fails with these changes. Here's the output: https://gist.github.com/jcohen/ac07d12c3f4c2c6b3db2
build.gradle
<https://reviews.apache.org/r/28361/#comment104952>
LocalSchedulerMain seems broken in general, but I recall that we needed to mark these directories as source directories so that running the scheduler from IntelliJ worked properly.
- Joshua Cohen
On Nov. 22, 2014, 1:35 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2014, 1:35 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 6894ceb7055c0491dce1c869fad0371d432f6540
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Kevin Sweeney <ke...@apache.org>.
> On Nov. 21, 2014, 6:16 p.m., Maxim Khutornenko wrote:
> > build.gradle, line 115
> > <https://reviews.apache.org/r/28361/diff/1/?file=772953#file772953line115>
> >
> > whitespaces?
fixed.
> On Nov. 21, 2014, 6:16 p.m., Maxim Khutornenko wrote:
> > build.gradle, line 577
> > <https://reviews.apache.org/r/28361/diff/1/?file=772953#file772953line577>
> >
> > revert or remove
fixed.
> On Nov. 21, 2014, 6:16 p.m., Maxim Khutornenko wrote:
> > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy, line 65
> > <https://reviews.apache.org/r/28361/diff/1/?file=772955#file772955line65>
> >
> > This is also defined in build.gradle. Any reason it has to be in both places?
fixed
> On Nov. 21, 2014, 6:16 p.m., Maxim Khutornenko wrote:
> > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy, line 66
> > <https://reviews.apache.org/r/28361/diff/1/?file=772955#file772955line66>
> >
> > same here
fixed.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62718
-----------------------------------------------------------
On Nov. 21, 2014, 5:35 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 5:35 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 6894ceb7055c0491dce1c869fad0371d432f6540
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Kevin Sweeney <ke...@apache.org>.
> On Nov. 21, 2014, 6:16 p.m., Maxim Khutornenko wrote:
> > build-support/thrift/thriftw, line 1
> > <https://reviews.apache.org/r/28361/diff/1/?file=772952#file772952line1>
> >
> > License header?
Fixed.
> On Nov. 21, 2014, 6:16 p.m., Maxim Khutornenko wrote:
> > build-support/thrift/thriftw, line 2
> > <https://reviews.apache.org/r/28361/diff/1/?file=772952#file772952line2>
> >
> > I don't see where EXPECTED_THRIFT_VERSION is used.
Fixed.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62718
-----------------------------------------------------------
On Nov. 25, 2014, 11:39 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 11:39 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 7b35dedb19143b27955c12c4df94ba98ff5f6608
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle 3e9cbfe6e6836f70fb9164f80973f3ebb813ef98
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/resources/scheduler/assets/scheduler/index.html f4ca07166aee21b8e6b7d3da82454e1b9b132f59
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62718
-----------------------------------------------------------
build-support/thrift/thriftw
<https://reviews.apache.org/r/28361/#comment104795>
License header?
build-support/thrift/thriftw
<https://reviews.apache.org/r/28361/#comment104796>
I don't see where EXPECTED_THRIFT_VERSION is used.
build.gradle
<https://reviews.apache.org/r/28361/#comment104793>
whitespaces?
build.gradle
<https://reviews.apache.org/r/28361/#comment104794>
revert or remove
buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy
<https://reviews.apache.org/r/28361/#comment104797>
This is also defined in build.gradle. Any reason it has to be in both places?
buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy
<https://reviews.apache.org/r/28361/#comment104798>
same here
- Maxim Khutornenko
On Nov. 22, 2014, 1:35 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2014, 1:35 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 6894ceb7055c0491dce1c869fad0371d432f6540
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Kevin Sweeney <ke...@apache.org>.
> On Nov. 24, 2014, 10:31 a.m., Zameer Manji wrote:
> > build.gradle, line 577
> > <https://reviews.apache.org/r/28361/diff/1/?file=772953#file772953line577>
> >
> > +1
fixed.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62827
-----------------------------------------------------------
On Nov. 21, 2014, 5:35 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 5:35 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 6894ceb7055c0491dce1c869fad0371d432f6540
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Kevin Sweeney <ke...@apache.org>.
> On Nov. 24, 2014, 10:31 a.m., Zameer Manji wrote:
> > build.gradle, line 315
> > <https://reviews.apache.org/r/28361/diff/1/?file=772953#file772953line315>
> >
> > Can we avoid declaring the version of libthrift twice? I see it here and in ThriftPluginExtension.
Fixed.
> On Nov. 24, 2014, 10:31 a.m., Zameer Manji wrote:
> > gradle/wrapper/gradle-wrapper.properties, line 6
> > <https://reviews.apache.org/r/28361/diff/1/?file=772957#file772957line6>
> >
> > What is the significance of this change?
It allows intellij to get the sources, which lets it do some autocompletion when editing .gradle files.
> On Nov. 24, 2014, 10:31 a.m., Zameer Manji wrote:
> > build.gradle, line 97
> > <https://reviews.apache.org/r/28361/diff/1/?file=772953#file772953line97>
> >
> > There seems to be trailing whitespace in this file.
fixed.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62827
-----------------------------------------------------------
On Nov. 21, 2014, 5:35 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 5:35 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 6894ceb7055c0491dce1c869fad0371d432f6540
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62827
-----------------------------------------------------------
build.gradle
<https://reviews.apache.org/r/28361/#comment104954>
There seems to be trailing whitespace in this file.
build.gradle
<https://reviews.apache.org/r/28361/#comment104957>
Can we avoid declaring the version of libthrift twice? I see it here and in ThriftPluginExtension.
build.gradle
<https://reviews.apache.org/r/28361/#comment104959>
+1
buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy
<https://reviews.apache.org/r/28361/#comment104961>
I think all of the .groovy files we use in our build need license headers.
gradle/wrapper/gradle-wrapper.properties
<https://reviews.apache.org/r/28361/#comment104964>
What is the significance of this change?
- Zameer Manji
On Nov. 21, 2014, 5:35 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 5:35 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 6894ceb7055c0491dce1c869fad0371d432f6540
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 28361: Extract thrift into an API subproject.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62716
-----------------------------------------------------------
This patch does not apply cleanly on master (a431b1d), do you need to rebase?
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 22, 2014, 1:35 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28361/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2014, 1:35 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-925
> https://issues.apache.org/jira/browse/AURORA-925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Extract thrift generation into an api subproject.
>
>
> Diffs
> -----
>
> .gitignore ec072d2cf7d9678c59d2f67ec3ab1fda3efd88b7
> BUILD b6d7ce983dfbb99dd7e26e547a4992a27a48ccdf
> build-support/python/make-pycharm-virtualenv 8f58d4df650892aff987ccfe47a9580023b8cf63
> build-support/release/make-python-sdists e0d20a19ef1fbc129a882b6368515a3ea41bab3f
> build-support/thrift/thriftw PRE-CREATION
> build.gradle 6894ceb7055c0491dce1c869fad0371d432f6540
> buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy f233153fd093cae255c1cb6807cfec6590ba36f9
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy PRE-CREATION
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy PRE-CREATION
> gradle/wrapper/gradle-wrapper.properties b04300260fd3975ec98a1a1d87b57025e7904c2f
> settings.gradle PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 4b9281590a9eeb8a8b571b909fd507259abfac44
> src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java c072010eddddd5a1856a05fa7e6c87b25c073059
> src/main/python/apache/aurora/admin/BUILD 9441e121bf4ea88a7ae286f8cd1cbd0c0ac89e06
> src/main/python/apache/aurora/client/BUILD 48566d99f432e6eb94d1bfdb18277205fd7bb9d8
> src/main/python/apache/aurora/client/api/BUILD 6d2a1bfe8531d800be651ec00518fc5b07a53474
> src/main/python/apache/aurora/client/cli/BUILD e6627a8a3c501292fdd31ec384320870db702bc2
> src/main/python/apache/aurora/client/commands/BUILD d146015d70715142618f2653538aca6beb83c1fc
> src/main/python/apache/aurora/client/hooks/BUILD f46cf650d9b471d08ed2b76652bca5d429f955ee
> src/main/python/apache/aurora/common/BUILD 02ec17ce35c6632df204ea4d1d12e61daf30dd1f
> src/main/python/apache/aurora/common/auth/BUILD c26d117122d17b2228b637441ce0aa564f5a8a3e
> src/main/python/apache/aurora/config/BUILD fa40ebdfdecae3eb13878d6f172a591c16507530
> src/main/python/apache/aurora/config/schema/BUILD 157c141bdf968666f31452784967de2a640d1815
> src/main/python/apache/aurora/executor/BUILD ca4193d31e3e3a71fa45f918058fba40fc911487
> src/main/python/apache/aurora/executor/common/BUILD d33e14b1cf7be7d115c7fe7741d52896f02f3aed
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d6bb5a120bb6368305ab52d253d25ad2bcfb3e8b
> src/main/python/apache/thermos/bin/BUILD 34e2b3fe1d1a49cc51db8f61339a21ff8e03e0f4
> src/main/python/apache/thermos/common/BUILD 918800b4ccb7bef61249d488ca8a4255168311bb
> src/main/python/apache/thermos/core/BUILD f362acdc395f1e479bcaf4bc063456abb1fdb0e2
> src/main/python/apache/thermos/monitoring/BUILD 0dad47e6337b7db33dca793f0324892d61e3433a
> src/main/python/apache/thermos/observer/BUILD b07db90906a06779f5369158469651425fefa1a3
> src/main/python/apache/thermos/testing/BUILD b96c166e9bc529b783071b5d37b78779a36d06c3
> src/main/thrift/org/apache/aurora/gen/BUILD
> src/main/thrift/org/apache/aurora/gen/api.thrift
> src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
> src/main/thrift/org/apache/aurora/gen/storage.thrift
> src/main/thrift/org/apache/aurora/gen/test.thrift
> src/main/thrift/org/apache/thermos/BUILD
> src/main/thrift/org/apache/thermos/thermos_internal.thrift
> src/test/python/apache/aurora/admin/BUILD 101aaa068f2a134f0e846359dc11c7a0ccc28dbb
> src/test/python/apache/aurora/client/api/BUILD f46ef695decd9b91112b9c933f6220efaa5a0bd3
> src/test/python/apache/aurora/client/commands/BUILD 000eafa95802d6cc835cae7c6f68016645dfe0f1
> src/test/python/apache/aurora/common/BUILD 3933c4616e1df667e7b2ce79e1a6df4c62ca73cf
> src/test/python/apache/aurora/config/BUILD 551595ec6268046817cb1f183d8b0c0af03f5cba
> src/test/python/apache/aurora/executor/BUILD 23a93fdb50c2492d4d8f4613796ff1723e3659fa
> src/test/python/apache/aurora/executor/common/BUILD 318e66d477bbf75d5e36ffe4bc70294da34b4965
>
> Diff: https://reviews.apache.org/r/28361/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Kevin Sweeney
>
>