You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2023/02/01 10:22:06 UTC
[GitHub] [cloudstack] DaanHoogland opened a new issue, #7155: tests should only run when applicable for adv-sg zone in such env
DaanHoogland opened a new issue, #7155:
URL: https://github.com/apache/cloudstack/issues/7155
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and main branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Documentation Report
* testing/CI
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
marvin
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on main branch.
-->
~~~
4.18
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
~~~
advanced zone with security groups.
~~~
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
##### SUMMARY
<!-- Explain the problem/feature briefly -->
when an advanced zone with security groups is used to test for regressions, a lot of errors occur.
an example
```
ERROR: test suite for <class 'tests.smoke.test_router_dns.TestRouterDns'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/nose/suite.py", line 210, in run
self.setUp()
File "/usr/local/lib/python3.6/site-packages/nose/suite.py", line 293, in setUp
self.setupContext(ancestor)
File "/usr/local/lib/python3.6/site-packages/nose/suite.py", line 316, in setupContext
try_run(context, names)
File "/usr/local/lib/python3.6/site-packages/nose/util.py", line 471, in try_run
return func()
File "/marvin/tests/smoke/test_router_dns.py", line 92, in setUpClass
zoneid=cls.zone.id)
File "/usr/local/lib/python3.6/site-packages/marvin/lib/base.py", line 3562, in create
return Network(apiclient.createNetwork(cmd).__dict__)
File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 2981, in createNetwork
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 381, in marvinRequest
raise e
File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 376, in marvinRequest
raise self.__lastError
File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackConnection.py", line 310, in __parseAndGetResponse
response_cls)
File "/usr/local/lib/python3.6/site-packages/marvin/jsonHelper.py", line 155, in getResultObj
raise cloudstackException.CloudstackAPIException(respname, errMsg)
marvin.cloudstackException.CloudstackAPIException: Execute cmd: createnetwork failed, due to: errorCode: 431, errorText:Only shared guest network can be created in security group enabled zone
```
this is not necessary as we know beforehand that these tests will fail.
Tests need to be properly tagged to not run in these environments.
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
<!-- Paste example playbooks or commands between quotes below -->
~~~
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] tests should only run when applicable for adv-sg zone in such env [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #7155:
URL: https://github.com/apache/cloudstack/issues/7155#issuecomment-2149753608
@lak7 I am unassigning you . please feel free to pick up when ready anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7155: tests should only run when applicable for adv-sg zone in such env
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #7155:
URL: https://github.com/apache/cloudstack/issues/7155#issuecomment-1411862701
good start !
@DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] tests should only run when applicable for adv-sg zone in such env [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7155:
URL: https://github.com/apache/cloudstack/issues/7155#issuecomment-5548460971
This issue is stale because it has been open for 120 days with no activity. It may be removed by administrators of this project at any time. Remove the stale label or comment to request for removal of it to prevent this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] lak7 commented on issue #7155: tests should only run when applicable for adv-sg zone in such env
Posted by "lak7 (via GitHub)" <gi...@apache.org>.
lak7 commented on issue #7155:
URL: https://github.com/apache/cloudstack/issues/7155#issuecomment-1415277060
I would love to handle this issue. Can you assign this issue to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #7155: tests should only run when applicable for adv-sg zone in such env
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #7155:
URL: https://github.com/apache/cloudstack/issues/7155#issuecomment-1415306298
go ahead @lak7 , create a PR and we'll go from there. Note however that creating a test environment with an advanced zone with security groups and a marvin test environment in no small feat if you are new to the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] tests should only run when applicable for adv-sg zone in such env [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #7155:
URL: https://github.com/apache/cloudstack/issues/7155#issuecomment-3805648202
@adithyanms-debug maybe this resolving this is not hard, but creating a list of tests that should not run in an advanced-zone with Security groups is. a regression test suite should be run against/inb such a zone and failures assessed to be genuine or due to not being applicable in such an environment. I will run such a test suite and link the results here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] lak7 commented on issue #7155: tests should only run when applicable for adv-sg zone in such env
Posted by "lak7 (via GitHub)" <gi...@apache.org>.
lak7 commented on issue #7155:
URL: https://github.com/apache/cloudstack/issues/7155#issuecomment-1415380042
Thanks! I will try my best.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] tests should only run when applicable for adv-sg zone in such env [cloudstack]
Posted by "adithyanms-debug (via GitHub)" <gi...@apache.org>.
adithyanms-debug commented on issue #7155:
URL: https://github.com/apache/cloudstack/issues/7155#issuecomment-3800634700
Hey guys i am new to open source contribution is it great to work with this issue as a beginner. If i can how should i approach this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org