[GitHub] [druid] dkoepke commented on pull request #14319: add configurable ColumnTypeMergePolicy to SegmentMetadataCache

["dkoepke (via GitHub)" <gi...@apache.org>]

dkoepke commented on PR #14319:
URL: https://github.com/apache/druid/pull/14319#issuecomment-1557827869

   Regarding naming:
   
   For `newestFirst`, "newest" without context might be confusing because it can refer either to when the segment was created/published OR the interval it covers. I believe the behavior is to select the segment with the latest interval (since the segments are sorted by segment ID, and the interval comes first in the ID), so a policy name like `latestInterval` might be clearer?
   
   For `leastRestrictive`, perhaps `bestFit` is clearer? My concern is that "least restrictive", while correct, can also refer to a policy that just chooses the widest possible type.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org