You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ga...@apache.org on 2019/03/19 13:28:46 UTC
[jclouds] branch master updated: JCLOUDS-1428 - Support for SAS
token based Authentication for Azure Blob Storage - removed sp and se
tokens from the check
This is an automated email from the ASF dual-hosted git repository.
gaul pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jclouds.git
The following commit(s) were added to refs/heads/master by this push:
new ba5a241 JCLOUDS-1428 - Support for SAS token based Authentication for Azure Blob Storage - removed sp and se tokens from the check
ba5a241 is described below
commit ba5a2418a5870d4e65499aa02043411fb6323f78
Author: d065488 <al...@sap.com>
AuthorDate: Tue Mar 19 12:26:41 2019 +0100
JCLOUDS-1428 - Support for SAS token based Authentication for Azure Blob Storage - removed sp and se tokens from the check
---
.../main/java/org/jclouds/azureblob/config/AzureBlobHttpApiModule.java | 2 +-
.../java/org/jclouds/azureblob/config/AzureBlobHttpApiModuleTest.java | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/providers/azureblob/src/main/java/org/jclouds/azureblob/config/AzureBlobHttpApiModule.java b/providers/azureblob/src/main/java/org/jclouds/azureblob/config/AzureBlobHttpApiModule.java
index fb6e2c0..264ad44 100644
--- a/providers/azureblob/src/main/java/org/jclouds/azureblob/config/AzureBlobHttpApiModule.java
+++ b/providers/azureblob/src/main/java/org/jclouds/azureblob/config/AzureBlobHttpApiModule.java
@@ -81,7 +81,7 @@ public class AzureBlobHttpApiModule extends HttpApiModule<AzureBlobClient> {
protected boolean authSAS(@org.jclouds.location.Provider Supplier<Credentials> creds) {
String credential = creds.get().credential;
String formattedCredential = credential.startsWith("?") ? credential.substring(1) : credential;
- List<String> required = ImmutableList.of("sv", "se", "sig", "sp");
+ List<String> required = ImmutableList.of("sv", "sig");
try {
Map<String, String> tokens = Splitter.on('&').withKeyValueSeparator('=').split(formattedCredential);
return all(required, in(tokens.keySet()));
diff --git a/providers/azureblob/src/test/java/org/jclouds/azureblob/config/AzureBlobHttpApiModuleTest.java b/providers/azureblob/src/test/java/org/jclouds/azureblob/config/AzureBlobHttpApiModuleTest.java
index 4ae8f87..c8c0cb3 100755
--- a/providers/azureblob/src/test/java/org/jclouds/azureblob/config/AzureBlobHttpApiModuleTest.java
+++ b/providers/azureblob/src/test/java/org/jclouds/azureblob/config/AzureBlobHttpApiModuleTest.java
@@ -37,7 +37,8 @@ public class AzureBlobHttpApiModuleTest {
{false, "sva=swajak&sta=stancyja&spa=spakoj&sea=mora&sig=podpis"},
{true, "sv=2018-03-28&ss=b&srt=sco&sp=r&se=2019-02-13T17:03:09Z&st=2019-02-13T09:03:09Z&spr=https&sig=wNkWK%2GURTjHWhtqG6Q2Gu%2Qu%3FPukW6N4%2FIH4Mr%2F%2FO42M%3D"},
{true, "sp=rl&st=2019-02-14T08:50:26Z&se=2019-02-15T08:50:26Z&sv=2018-03-28&sig=Ukow8%2GtpQpAiVZBLcWp1%2RSpFq928MAqzp%2BdrdregaB6%3D&sr=b"},
- {false, ""}
+ {false, ""},
+ {true, "sig=Ukow8%2GtpQpAiVZBLcWp1%2RSpFq928MAqzp%2BdrdregaB6%3D\u0026sv=2018-03-28"}
};
}