You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@fluo.apache.org by gi...@git.apache.org on 2017/09/25 21:27:44 UTC

[GitHub] mikewalch commented on a change in pull request #930: Add info about pull request

mikewalch commented on a change in pull request #930: Add info about pull request
URL: https://github.com/apache/fluo/pull/930#discussion_r140903548
 
 

 ##########
 File path: CONTRIBUTING.md
 ##########
 @@ -34,6 +34,11 @@ Fluo has a test suite that consists of the following:
 *  Integration tests which are run using `mvn verify`. These tests start a local Fluo instance
    (called MiniFluo) and run against it.
 
+## Pull Request
+
+Before making a pull request please attempt to run `mvn verify`.  If it fails and you are not sure 
+why, go ahead make the pull request.
 
 Review comment:
   could be `it's OK to go ahead and make the pull request.`
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services