You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2017/08/03 21:17:12 UTC

kudu git commit: [clock] fixed link error on OS X

Repository: kudu
Updated Branches:
  refs/heads/master e5202d30a -> b04490b86


[clock] fixed link error on OS X

kudu_common is needed to link the clock library, otherwise the following
error is output on OS X:

  Undefined symbols for architecture x86_64:
    "kudu::Timestamp::kInvalidTimestamp", referenced from:
        kudu::Timestamp::Timestamp() in hybrid_clock.cc.o
        kudu::clock::LogicalClock::Update(kudu::Timestamp const&) \
            in logical_clock.cc.o
    "kudu::Timestamp::ToUint64() const", referenced from:
        kudu::clock::HybridClock::NowForMetrics() in hybrid_clock.cc.o
        kudu::clock::LogicalClock::Stringify(kudu::Timestamp) \
            in logical_clock.cc.o
  ld: symbol(s) not found for architecture x86_64
  clang: error: linker command failed with exit code 1 \
      (use -v to see invocation)

Change-Id: I5e5442333fb667b50aca2f8229e223d44edffd14
Reviewed-on: http://gerrit.cloudera.org:8080/7578
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/b04490b8
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/b04490b8
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/b04490b8

Branch: refs/heads/master
Commit: b04490b8647e17ba4028a1765b5608b38e53490b
Parents: e5202d3
Author: Alexey Serbin <as...@cloudera.com>
Authored: Thu Aug 3 12:15:11 2017 -0700
Committer: Alexey Serbin <as...@cloudera.com>
Committed: Thu Aug 3 21:16:18 2017 +0000

----------------------------------------------------------------------
 src/kudu/clock/CMakeLists.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/b04490b8/src/kudu/clock/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/src/kudu/clock/CMakeLists.txt b/src/kudu/clock/CMakeLists.txt
index 0e94f4a..46ebe3b 100644
--- a/src/kudu/clock/CMakeLists.txt
+++ b/src/kudu/clock/CMakeLists.txt
@@ -28,10 +28,10 @@ endif()
 add_library(clock ${CLOCK_SRCS})
 
 target_link_libraries(clock
+  kudu_common
   kudu_util)
 
 set(KUDU_TEST_LINK_LIBS ${KUDU_MIN_TEST_LIBS}
-  clock
-  kudu_common)
+  clock)
 ADD_KUDU_TEST(hybrid_clock-test)
 ADD_KUDU_TEST(logical_clock-test)