You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2017/03/10 15:10:54 UTC
[GitHub] brooklyn-docs pull request #154: WinRM CMD feed usage
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-docs/pull/154
WinRM CMD feed usage
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-docs winrmcmd_feed
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-docs/pull/154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #154
----
commit f74e6eaee6f659ed1dbed4fff2fc36f046e29f92
Author: Valentin Aitken <bo...@gmail.com>
Date: 2017-03-10T15:08:34Z
WinRM CMD feed usage
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-docs pull request #154: WinRM CMD feed usage
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/154#discussion_r105683376
--- Diff: guide/java/feeds.md ---
@@ -67,15 +69,15 @@ protected void disconnectSensors() {
An SSH feed executes a command over ssh periodically. An example is shown below:
{% highlight java %}
-private SshFeed feed;
+private AbstractCommandFeed feed;
//@Override
--- End diff --
@drigodwin I uncommented it similar to `disconnectSensors` method mentioned in the example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-docs pull request #154: WinRM CMD feed usage
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/154#discussion_r105682033
--- Diff: guide/java/feeds.md ---
@@ -67,15 +69,15 @@ protected void disconnectSensors() {
An SSH feed executes a command over ssh periodically. An example is shown below:
{% highlight java %}
-private SshFeed feed;
+private AbstractCommandFeed feed;
//@Override
--- End diff --
Why have a commented out `@Override` here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-docs pull request #154: WinRM CMD feed usage
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-docs/pull/154
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---