You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Colin Chalmers <co...@maxware.nl> on 2002/07/11 12:48:15 UTC
PATCH IntakeService DateString
Hi,
Although the IntakeService in Fulcrum contains a DateString class this
doesn't seem to be present in Turbine-2.2. This patch addresses that problem
1. DateStringField has been copied from Fulcrum and adapted for Turbine-2.2
2. DateStringValidator has been copied from Fulcrum and adapted for
Turbine-2.2
3. FieldFactory has been adapted to work with DateString. Hereby a diff
Could someone check in these three files please?
/Colin
> Colin Chalmers wrote:
> > With the talk concerning a 2.2 release with decoupled Torque possibly
> > without Fulcrum I have a comment concerning the Intake Service. In the
> > Fulcrum version there is support for DateStringField and
Group.GroupFactory
> > which are not present in 2.2. This caused us some problems recently as
we
> > use DateString. I could provide a patch for this for 2.2 unless they
should
> > be omitted for a specific reason?
>
> send the patch and i'll commit it for you ;-)
>
> martin
>
> >
> > Also there was talk of replacing the scheduler server with perhaps
Quartz?
> > Is there any news on that front?
>
>
>
> >
> > /Colin
> >
> >
> > --
> > To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> > For additional commands, e-mail:
<ma...@jakarta.apache.org>
> >
>
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
>
RE: PATCH IntakeService DateString
Posted by Stephen Haberman <st...@chase3000.com>.
> The original reasoning behind the name DateString is that I was still
> considering how to create a Date field/validator the would work from
> separate inputs for month/day/year/hour/minute. I still have not
needed
> such a thing, but I thought it best not to take the shorter and more
> general "Date" namespace out of use for other ways of entering a date.
Huh, I hadn't thought of having multiple form fields for a single
date...that'd be pretty cool. And the idea of keeping Date open for
other uses has good intentions, but isn't the current DateString the
most generic/only implementation that most people would use?
I would think any variations of DateString that could potentially take
the Date name would be specialized enough to where it would be confusing
for them to use Date and instead would have names more specific to their
purpose, e.g. DateMonth or the like.
The Date/DateString isn't critical, but I spent a good time chasing it
down when I was originally using Date, first because it made sense to
map to my Date properties and second because it was in the DTD. :-)
I'm fine either way...just let me know whether I should submit a patch
changing DateString->Date (which I already have on my build of Fulcrum,
btw :-) or updating the DTD with Date->DateString.
Thanks,
Stephen
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: PATCH IntakeService DateString
Posted by John McNally <jm...@collab.net>.
The original reasoning behind the name DateString is that I was still
considering how to create a Date field/validator the would work from
separate inputs for month/day/year/hour/minute. I still have not needed
such a thing, but I thought it best not to take the shorter and more
general "Date" namespace out of use for other ways of entering a date.
john mcnally
On Thu, 2002-07-11 at 13:54, Stephen Haberman wrote:
>
> > > Although the IntakeService in Fulcrum contains a DateString class
> this
> > > doesn't seem to be present in Turbine-2.2. This patch addresses that
> problem
> > >
> > > 1. DateStringField has been copied from Fulcrum and adapted for
> Turbine-2.2
> > > 2. DateStringValidator has been copied from Fulcrum and adapted for
> > > Turbine-2.2
> > > 3. FieldFactory has been adapted to work with DateString. Hereby a
> diff
> > >
> > > Could someone check in these three files please?
> >
> > done
> >
> > thanx!
> >
> > martin
>
> Could we rename DateString to just Date? I think it's more
> representative of what it actually is...because the DateString
> functionality targets Date properties on objects, not String properties
> that are in a date format. E.g. if you have an integer property, you use
> "int" not "IntegerString".
>
> Also note that Date matches the existing DTD:
> http://jakarta.apache.org/turbine/dtd/intake.dtd.
>
> I'd be happy to submit the patches (for both Fulcrum and Turbine-2) if
> it'll be committed.
>
> Thanks,
> Stephen
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: PATCH IntakeService DateString
Posted by Stephen Haberman <st...@chase3000.com>.
> > Although the IntakeService in Fulcrum contains a DateString class
this
> > doesn't seem to be present in Turbine-2.2. This patch addresses that
problem
> >
> > 1. DateStringField has been copied from Fulcrum and adapted for
Turbine-2.2
> > 2. DateStringValidator has been copied from Fulcrum and adapted for
> > Turbine-2.2
> > 3. FieldFactory has been adapted to work with DateString. Hereby a
diff
> >
> > Could someone check in these three files please?
>
> done
>
> thanx!
>
> martin
Could we rename DateString to just Date? I think it's more
representative of what it actually is...because the DateString
functionality targets Date properties on objects, not String properties
that are in a date format. E.g. if you have an integer property, you use
"int" not "IntegerString".
Also note that Date matches the existing DTD:
http://jakarta.apache.org/turbine/dtd/intake.dtd.
I'd be happy to submit the patches (for both Fulcrum and Turbine-2) if
it'll be committed.
Thanks,
Stephen
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: PATCH IntakeService DateString
Posted by Martin Poeschl <mp...@marmot.at>.
Colin Chalmers wrote:
> Hi,
>
> Although the IntakeService in Fulcrum contains a DateString class this
> doesn't seem to be present in Turbine-2.2. This patch addresses that problem
>
> 1. DateStringField has been copied from Fulcrum and adapted for Turbine-2.2
> 2. DateStringValidator has been copied from Fulcrum and adapted for
> Turbine-2.2
> 3. FieldFactory has been adapted to work with DateString. Hereby a diff
>
> Could someone check in these three files please?
done
thanx!
martin
>
> /Colin
>
>
>
>
>
>
>>Colin Chalmers wrote:
>>
>>>With the talk concerning a 2.2 release with decoupled Torque possibly
>>>without Fulcrum I have a comment concerning the Intake Service. In the
>>>Fulcrum version there is support for DateStringField and
>>
> Group.GroupFactory
>
>>>which are not present in 2.2. This caused us some problems recently as
>>
> we
>
>>>use DateString. I could provide a patch for this for 2.2 unless they
>>
> should
>
>>>be omitted for a specific reason?
>>
>>send the patch and i'll commit it for you ;-)
>>
>>martin
>>
>>
>>>Also there was talk of replacing the scheduler server with perhaps
>>
> Quartz?
>
>>>Is there any news on that front?
>>
>>
>>
>>>/Colin
>>>
>>>
>>>--
>>>To unsubscribe, e-mail:
>>
> <ma...@jakarta.apache.org>
>
>>>For additional commands, e-mail:
>>
> <ma...@jakarta.apache.org>
>
>>
>>
>>--
>>To unsubscribe, e-mail:
>
> <ma...@jakarta.apache.org>
>
>>For additional commands, e-mail:
>
> <ma...@jakarta.apache.org>
>
>>
>>
>>------------------------------------------------------------------------
>>
>>Index: ./src/java/org/apache/turbine/services/intake/model/FieldFactory.java
>>===================================================================
>>RCS file: /home/cvspublic/jakarta-turbine-2/src/java/org/apache/turbine/services/intake/model/FieldFactory.java,v
>>retrieving revision 1.3
>>diff -r1.3 FieldFactory.java
>>147a148,157
>>
>>> fieldCtors.put("DateString", new FieldFactory.FieldCtor()
>>> {
>>> public Field getInstance(XmlField f, Group g)
>>> throws Exception
>>> {
>>> return new DateStringField(f, g);
>>> }
>>> }
>>> );
>>>
>>
>>
>>The command completed successfully.
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>