Re: [PR] feat(datafusion-functions-aggregate): add support for lists and other nested types in min and max [datafusion]

["gabotechs (via GitHub)" <gi...@apache.org>]

gabotechs commented on code in PR #15857:
URL: https://github.com/apache/datafusion/pull/15857#discussion_r2062676790


##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -726,6 +726,8 @@ fn extract_window_frame_target_type(col_type: &DataType) -> Result<DataType> {
         Ok(DataType::Interval(IntervalUnit::MonthDayNano))
     } else if let DataType::Dictionary(_, value_type) = col_type {
         extract_window_frame_target_type(value_type)
+    } else if let DataType::List(field) = col_type {
+        extract_window_frame_target_type(field.data_type())

Review Comment:
   Not 100% sure what am I doing here. This seems necessary for window functions over min/max aggregations on lists to work, and does not seem to be breaking other things, but maybe more experienced DF folks can throw some light here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org