[GitHub] [hive] pvary commented on a change in pull request #2058: HIVE-24867: Create iceberg-handler module in Hive

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2058:
URL: https://github.com/apache/hive/pull/2058#discussion_r591731830



##########
File path: iceberg-handler/pom.xml
##########
@@ -0,0 +1,189 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <parent>
+        <groupId>org.apache.hive</groupId>
+        <artifactId>hive</artifactId>
+        <version>4.0.0-SNAPSHOT</version>
+        <relativePath>../pom.xml</relativePath>
+    </parent>
+    <modelVersion>4.0.0</modelVersion>
+
+    <artifactId>iceberg-handler</artifactId>
+    <packaging>jar</packaging>
+    <name>Hive Iceberg Handler</name>
+
+    <properties>
+        <hive.path.to.root>..</hive.path.to.root>
+        <iceberg-api.version>0.11.0</iceberg-api.version>

Review comment:
       I would prefer to have this in the top level pom. `iceberg.version`
   Why is this here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org