[jira] [Resolved] (DIRMINA-948) Performance recession when invoke session.write concurrent

["Emmanuel Lecharny (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DIRMINA-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Lecharny resolved DIRMINA-948.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.8

Fixed with http://git-wip-us.apache.org/repos/asf/mina/commit/f72467ad

Many thanks for the proposed solution !

> Performance recession when invoke session.write concurrent
> ----------------------------------------------------------
>
>                 Key: DIRMINA-948
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-948
>             Project: MINA
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.7
>            Reporter: Mark
>              Labels: performance
>             Fix For: 2.0.8
>
>
> In org.apache.mina.core.filterchainDefaultIoFilterChain, code around line number 600, 
> <code>if (writeRequestQueue.size() == 0 )</code>
> will raise performance problem in high concurrent situation, Mina default use ConcurrentLinkedQueue as writeRequestQueue, but size() of this queue is not a constant-time operation, suggest to use <code>if (writeRequestQueue.isEmpty(s))</code> instead of it.



--
This message was sent by Atlassian JIRA
(v6.1#6144)