You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/02/08 12:47:46 UTC

[GitHub] flink pull request #5429: [FLINK-8604] [rest] Move JobTerminationHandler int...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5429

    [FLINK-8604] [rest] Move JobTerminationHandler into WebMonitorEndpoint

    ## What is the purpose of the change
    
    Register the JobTerminationHandler at the WebMonitorEndpoint to make it accessible to
    all REST endpoints.
    
    ## Verifying this change
    
    - Tested manually
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink moveTerminationHandler

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5429.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5429
    
----
commit 216876ae1d3fd0509bd5591576d9d4c960c1aa80
Author: Till Rohrmann <tr...@...>
Date:   2018-02-06T18:11:53Z

    [hotfix] Change shutdown order in WebMonitorEndpoint to avoid illegal state

commit f906423456b0f42c46213584b91d7c75321289c5
Author: Till Rohrmann <tr...@...>
Date:   2018-02-08T12:43:09Z

    [FLINK-8604] [rest] Move JobTerminationHandler into WebMonitorEndpoint
    
    Register the JobTerminationHandler at the WebMonitorEndpoint to make it accessible to
    all REST endpoints.

----


---

[GitHub] flink pull request #5429: [FLINK-8604] [rest] Move JobTerminationHandler int...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5429


---

[GitHub] flink issue #5429: [FLINK-8604] [rest] Move JobTerminationHandler into WebMo...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/5429
  
    Merging this PR.


---