You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/24 12:21:52 UTC

[GitHub] [flink] azagrebin opened a new pull request #8857: [FLINK-12960][coordination][shuffle] Move ResultPartitionDeploymentDescriptor#releasedOnConsumption to PartitionDescriptor#releasedOnConsumption

azagrebin opened a new pull request #8857: [FLINK-12960][coordination][shuffle] Move ResultPartitionDeploymentDescriptor#releasedOnConsumption to PartitionDescriptor#releasedOnConsumption
URL: https://github.com/apache/flink/pull/8857
 
 
   ## What is the purpose of the change
   
   ResultPartitionDeploymentDescriptor#releasedOnConsumption shows the intention how the partition is going to be used by the shuffle user. If it is not supported by the shuffle service for a certain type of partition, ShuffleMaster#registerPartitionWithProducer and ShuffleEnvironment#createResultPartitionWriters should throw an exception. ShuffleMaster#registerPartitionWithProducer takes PartitionDescriptor. ResultPartitionDeploymentDescriptor#releasedOnConsumption should be part of PartitionDescriptor so that not only ShuffleEnvironment but also ShuffleMaster is already aware about releasedOnConsumption.
   
   ## Brief change log
   
     - Move ResultPartitionDeploymentDescriptor#releasedOnConsumption to PartitionDescriptor#releasedOnConsumption
     - Introduce NettyShuffleUtils#checkReleaseOnConsumptionIsSupportedForPartition
     - call NettyShuffleUtils#checkReleaseOnConsumptionIsSupportedForPartition in NettyShuffleMaster#registerPartitionWithProducer and NettyShuffleEnvironment#createResultPartitionWriters
   
   ## Verifying this change
   
   Simple refactoring covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services