You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by vieiro <gi...@git.apache.org> on 2017/10/02 10:01:25 UTC

[GitHub] incubator-netbeans pull request #37: [NETBEANS-54] Module Review editor.lib

GitHub user vieiro opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/37

    [NETBEANS-54] Module Review editor.lib

    - no external libraries
    - checked Rat report: modified license header in src/org/netbeans/editor/BaseKit.java
    - skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vieiro/incubator-netbeans netbeans-54-module-review-editor.lib

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
    
----
commit 2993d25f8c12ebf6e2b8ec5bdbe4a1f32e447a0c
Author: Antonio Vieiro <an...@vieiro.net>
Date:   2017-10-02T09:47:44Z

    [NETBEANS-54] Module Review editor.lib
    - no external libraries
    - checked Rat report: modified license header in src/org/netbeans/editor/BaseKit.java

----


---

[GitHub] incubator-netbeans issue #37: [NETBEANS-54] Module Review editor.lib

Posted by matthiasblaesing <gi...@git.apache.org>.

Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/37
  
    Merged with 3 positive reviews - Thank you.


---

[GitHub] incubator-netbeans pull request #37: [NETBEANS-54] Module Review editor.lib

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-netbeans/pull/37


---