You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/06/08 23:03:46 UTC
[kudu-CR] Enable move constructors for protobufs
Todd Lipcon has posted comments on this change.
Change subject: Enable move constructors for protobufs
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6900/2/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
Line 343: # Do a clean build if the patchlevel changed.
> Neat. I think this would be a pretty useful thing to do in general. Would y
mind if I hold off and just wait until we port this all to python? (some day I'll revive that)
--
To view, visit http://gerrit.cloudera.org:8080/6900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I775e770799aec44cda79e641980e91259d19e650
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes