You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by wongoo <wo...@apache.org> on 2021/03/14 14:44:42 UTC
[VOTE] Release Apache dubbo-go-hessian2 v1.9.0 RC1
Hello Dubbo/Dubbogo Community,
This is a call for a vote to release Apache dubbo-go-hessian2 version
v1.9.0 RC1.
The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.9.0-rc1/
Git tag for the release:
https://github.com/apache/dubbo-go-hessian2/tree/1.9
Hash for the release tag: d829b56bf3e56a2f424ef4555eb15ec8b131b3c9
Release Notes:
https://github.com/apache/dubbo-go-hessian2/blob/1.9/CHANGE.md
The artifacts have been signed with Key :7DB68550D366E4C0, which can be
found in the keys file:
https://dist.apache.org/repos/dist/dev/dubbo/KEYS
The vote will be open for at least 72 hours or until a necessary number of
votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thanks,
The Apache Dubbo-go Team
Re: [VOTE] Release Apache dubbo-go-hessian2 v1.9.0 RC1
Posted by Ian Luo <ia...@gmail.com>.
I checked the following items. I vote +1 (binding) to this release.
[v] Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?
I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because.
-Ian.
On Sun, Mar 14, 2021 at 10:44 PM wongoo <wo...@apache.org> wrote:
> Hello Dubbo/Dubbogo Community,
>
> This is a call for a vote to release Apache dubbo-go-hessian2 version
> v1.9.0 RC1.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.9.0-rc1/
> Git tag for the release:
> https://github.com/apache/dubbo-go-hessian2/tree/1.9
> Hash for the release tag: d829b56bf3e56a2f424ef4555eb15ec8b131b3c9
> Release Notes:
> https://github.com/apache/dubbo-go-hessian2/blob/1.9/CHANGE.md
> The artifacts have been signed with Key :7DB68550D366E4C0, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo-go Team
>
Re: [VOTE] Release Apache dubbo-go-hessian2 v1.9.0 RC1
Posted by Ian Luo <ia...@gmail.com>.
Pls. ignore. I reply to the wrong thread.
-Ian.
On Mon, Mar 15, 2021 at 10:31 AM Ian Luo <ia...@gmail.com> wrote:
> +1, glad to see another dubbo-go side project.
>
> Thanks,
> -Ian.
>
> On Sun, Mar 14, 2021 at 10:44 PM wongoo <wo...@apache.org> wrote:
>
>> Hello Dubbo/Dubbogo Community,
>>
>> This is a call for a vote to release Apache dubbo-go-hessian2 version
>> v1.9.0 RC1.
>>
>> The release candidates:
>> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.9.0-rc1/
>> Git tag for the release:
>> https://github.com/apache/dubbo-go-hessian2/tree/1.9
>> Hash for the release tag: d829b56bf3e56a2f424ef4555eb15ec8b131b3c9
>> Release Notes:
>> https://github.com/apache/dubbo-go-hessian2/blob/1.9/CHANGE.md
>> The artifacts have been signed with Key :7DB68550D366E4C0, which can be
>> found in the keys file:
>> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>>
>> The vote will be open for at least 72 hours or until a necessary number
>> of
>> votes are reached.
>>
>> Please vote accordingly:
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>>
>> Thanks,
>> The Apache Dubbo-go Team
>>
>
Re: [VOTE] Release Apache dubbo-go-hessian2 v1.9.0 RC1
Posted by Ian Luo <ia...@gmail.com>.
+1, glad to see another dubbo-go side project.
Thanks,
-Ian.
On Sun, Mar 14, 2021 at 10:44 PM wongoo <wo...@apache.org> wrote:
> Hello Dubbo/Dubbogo Community,
>
> This is a call for a vote to release Apache dubbo-go-hessian2 version
> v1.9.0 RC1.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.9.0-rc1/
> Git tag for the release:
> https://github.com/apache/dubbo-go-hessian2/tree/1.9
> Hash for the release tag: d829b56bf3e56a2f424ef4555eb15ec8b131b3c9
> Release Notes:
> https://github.com/apache/dubbo-go-hessian2/blob/1.9/CHANGE.md
> The artifacts have been signed with Key :7DB68550D366E4C0, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo-go Team
>
Re: [VOTE] Release Apache dubbo-go-hessian2 v1.9.0 RC1
Posted by Jun Liu <li...@apache.org>.
+1
I checked:
* All files have ASF license header by running the script provided by project
* Signatures and hashes are good
* LICENSE exists
* Can compile from source
Jun
> On Mar 14, 2021, at 10:44 PM, wongoo <wo...@apache.org> wrote:
>
> Hello Dubbo/Dubbogo Community,
>
> This is a call for a vote to release Apache dubbo-go-hessian2 version
> v1.9.0 RC1.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.9.0-rc1/
> Git tag for the release:
> https://github.com/apache/dubbo-go-hessian2/tree/1.9
> Hash for the release tag: d829b56bf3e56a2f424ef4555eb15ec8b131b3c9
> Release Notes:
> https://github.com/apache/dubbo-go-hessian2/blob/1.9/CHANGE.md
> The artifacts have been signed with Key :7DB68550D366E4C0, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo-go Team
Re: [VOTE] Release Apache dubbo-go-hessian2 v1.9.0 RC1
Posted by stocks alex <al...@apache.org>.
+1 approve.
however, there are slight errors need to be fixed.
1 const.go line 34: the comment word constants should be constants.
2 hessian.go line 41: add clearly comment for PackageType.
3 ref.go line 30: the name of _refElem should be changed as I have not seen
other words begin with "_" in goland src codes.
wongoo <wo...@apache.org> 于2021年3月14日周日 下午10:44写道：
> Hello Dubbo/Dubbogo Community,
>
> This is a call for a vote to release Apache dubbo-go-hessian2 version
> v1.9.0 RC1.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.9.0-rc1/
> Git tag for the release:
> https://github.com/apache/dubbo-go-hessian2/tree/1.9
> Hash for the release tag: d829b56bf3e56a2f424ef4555eb15ec8b131b3c9
> Release Notes:
> https://github.com/apache/dubbo-go-hessian2/blob/1.9/CHANGE.md
> The artifacts have been signed with Key :7DB68550D366E4C0, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo-go Team
>