You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nlpcraft.apache.org by se...@apache.org on 2020/05/11 08:52:16 UTC
[incubator-nlpcraft] branch NLPCRAFT-30 updated: Some comments.
This is an automated email from the ASF dual-hosted git repository.
sergeykamov pushed a commit to branch NLPCRAFT-30
in repository https://gitbox.apache.org/repos/asf/incubator-nlpcraft.git
The following commit(s) were added to refs/heads/NLPCRAFT-30 by this push:
new 137ecd7 Some comments.
137ecd7 is described below
commit 137ecd76b1833c05c4ffd023d0e66a6ce4f9ab44
Author: Sergey Kamov <se...@apache.org>
AuthorDate: Mon May 11 11:52:06 2020 +0300
Some comments.
---
src/main/resources/nlpcraft.conf | 3 +--
src/main/scala/org/apache/nlpcraft/examples/sql/db/SqlServer.scala | 4 ++--
.../scala/org/apache/nlpcraft/examples/sql/db/SqlValueLoader.scala | 2 +-
.../scala/org/apache/nlpcraft/model/tools/sqlgen/NCSqlExtractor.java | 2 +-
src/main/scala/org/apache/nlpcraft/model/tools/sqlgen/NCSqlSort.java | 2 +-
.../org/apache/nlpcraft/model/tools/test/NCTestClientBuilder.java | 2 +-
.../apache/nlpcraft/probe/mgrs/nlp/NCProbeEnrichmentManager.scala | 5 +++--
7 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/main/resources/nlpcraft.conf b/src/main/resources/nlpcraft.conf
index 5d3917c..b9d2bd0 100644
--- a/src/main/resources/nlpcraft.conf
+++ b/src/main/resources/nlpcraft.conf
@@ -234,8 +234,7 @@ nlpcraft {
# NOTE: These is an example.
# Start data probe with this configuration file to deploy example data model.
models = [
- "org.apache.nlpcraft.examples.echo.EchoModel",
- "org.apache.nlpcraft.examples.sql.SqlModel"
+ "org.apache.nlpcraft.examples.echo.EchoModel"
// Requires 'google' on the server side.
// See https://nlpcraft.apache.org/integrations.html#nlp for more details
diff --git a/src/main/scala/org/apache/nlpcraft/examples/sql/db/SqlServer.scala b/src/main/scala/org/apache/nlpcraft/examples/sql/db/SqlServer.scala
index 600d959..ebc60ab 100644
--- a/src/main/scala/org/apache/nlpcraft/examples/sql/db/SqlServer.scala
+++ b/src/main/scala/org/apache/nlpcraft/examples/sql/db/SqlServer.scala
@@ -25,7 +25,7 @@ import org.h2.jdbcx.JdbcDataSource
import org.h2.tools.Server
/**
- * TODO
+ * TODO add description.
*
* H2 database should be started before probe is started.
* Usually H2 started in memory mode for such examples,
@@ -104,7 +104,7 @@ object SqlServer extends LazyLogging {
}
/**
- * TODO:
+ * TODO: add description.
*/
object SqlServerRunner extends App {
SqlServer.start()
diff --git a/src/main/scala/org/apache/nlpcraft/examples/sql/db/SqlValueLoader.scala b/src/main/scala/org/apache/nlpcraft/examples/sql/db/SqlValueLoader.scala
index 24fe07a..8f98b53 100644
--- a/src/main/scala/org/apache/nlpcraft/examples/sql/db/SqlValueLoader.scala
+++ b/src/main/scala/org/apache/nlpcraft/examples/sql/db/SqlValueLoader.scala
@@ -27,7 +27,7 @@ import scala.collection.JavaConverters._
import scala.language.implicitConversions
/**
- * TODO
+ * TODO add description.
*/
class SqlValueLoader extends NCValueLoader with LazyLogging {
override def load(e: NCElement): java.util.Set[NCValue] = {
diff --git a/src/main/scala/org/apache/nlpcraft/model/tools/sqlgen/NCSqlExtractor.java b/src/main/scala/org/apache/nlpcraft/model/tools/sqlgen/NCSqlExtractor.java
index bd5ad2b..4fe5ed9 100644
--- a/src/main/scala/org/apache/nlpcraft/model/tools/sqlgen/NCSqlExtractor.java
+++ b/src/main/scala/org/apache/nlpcraft/model/tools/sqlgen/NCSqlExtractor.java
@@ -46,7 +46,7 @@ public interface NCSqlExtractor {
NCSqlLimit extractLimit(NCToken limitTok);
/**
- * TODO:
+ * TODO: fix description.
* Extracts sort object from given <code>nlpcraft:sort</code> token.
*
* @param sortTok Sort token with ID <code>nlpcraft:sort</code>.
diff --git a/src/main/scala/org/apache/nlpcraft/model/tools/sqlgen/NCSqlSort.java b/src/main/scala/org/apache/nlpcraft/model/tools/sqlgen/NCSqlSort.java
index f41e3d3..4860304 100644
--- a/src/main/scala/org/apache/nlpcraft/model/tools/sqlgen/NCSqlSort.java
+++ b/src/main/scala/org/apache/nlpcraft/model/tools/sqlgen/NCSqlSort.java
@@ -27,7 +27,7 @@ import org.apache.nlpcraft.model.NCToken;
*/
public interface NCSqlSort {
/**
- * TODO:
+ * TODO: add description.
*/
NCSqlColumn getColumn();
diff --git a/src/main/scala/org/apache/nlpcraft/model/tools/test/NCTestClientBuilder.java b/src/main/scala/org/apache/nlpcraft/model/tools/test/NCTestClientBuilder.java
index 9b2f231..7ad9f72 100644
--- a/src/main/scala/org/apache/nlpcraft/model/tools/test/NCTestClientBuilder.java
+++ b/src/main/scala/org/apache/nlpcraft/model/tools/test/NCTestClientBuilder.java
@@ -153,7 +153,7 @@ public class NCTestClientBuilder {
return this;
}
- // TODO:
+ // TODO: add description.
public NCTestClientBuilder setResponseLog(boolean respLog) {
impl.setResponseLog(respLog);
diff --git a/src/main/scala/org/apache/nlpcraft/probe/mgrs/nlp/NCProbeEnrichmentManager.scala b/src/main/scala/org/apache/nlpcraft/probe/mgrs/nlp/NCProbeEnrichmentManager.scala
index a2d192e..a25316b 100644
--- a/src/main/scala/org/apache/nlpcraft/probe/mgrs/nlp/NCProbeEnrichmentManager.scala
+++ b/src/main/scala/org/apache/nlpcraft/probe/mgrs/nlp/NCProbeEnrichmentManager.scala
@@ -403,8 +403,8 @@ object NCProbeEnrichmentManager extends NCService with NCOpenCensusModelStats {
)
diffRedundant.foreach { case (del, similar) ⇒
- // TODO: log level
- logger.info(s"Redundant note removed: $del, because similar exists: $similar")
+ if (DEEP_DEBUG)
+ logger.trace(s"Redundant note removed: $del, because similar exists: $similar")
nlpSen.removeNote(del)
}
@@ -427,6 +427,7 @@ object NCProbeEnrichmentManager extends NCService with NCOpenCensusModelStats {
// Loop has sense if model is complex (has user defined parsers or DSL based synonyms)
continue = NCModelEnricher.isComplex(mdlDec) && res.exists { case (_, same) ⇒ !same }
+ if (DEEP_DEBUG)
if (continue) {
val changed = res.filter(!_._2).keys.map(_.getClass.getSimpleName).mkString(", ")