You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:59:45 UTC

[GitHub] [incubator-apisix] afghanistanyn commented on a change in pull request #1917: add nacos support

afghanistanyn commented on a change in pull request #1917:
URL: https://github.com/apache/incubator-apisix/pull/1917#discussion_r461981656



##########
File path: apisix/discovery/nacos.lua
##########
@@ -165,7 +165,7 @@ local function fetch_instance(service)
     local json_str = res.body
     local data, err = core.json.decode(json_str)
     if not data then
-        log.error("get instance from nacos for " .. service  .. ", invalid response body: ", json_str, " err: ", err)
+        log.error("get instance for "..service..",invalid response body: ",json_str, " err: ", err)

Review comment:
       help 
   could you help correct it and add some test cases， it’s too hard for me
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org