You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "gnehil (via GitHub)" <gi...@apache.org> on 2023/11/15 03:27:54 UTC
[PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
gnehil opened a new pull request, #27013:
URL: https://github.com/apache/doris/pull/27013
## Proposed changes
Issue Number: close #xxx
When the new distribution column is inconsistent with the default distribution column, the new distribution column is output twice in the log information, but the default distribution column is not output.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27013:
URL: https://github.com/apache/doris/pull/27013#issuecomment-1840052917
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.49 seconds
stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17163919709 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27013:
URL: https://github.com/apache/doris/pull/27013#issuecomment-1840111246
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27013:
URL: https://github.com/apache/doris/pull/27013#issuecomment-1840090612
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 81209ef095706126e4014426c38b459ff0498e81, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4885 4682 4749 4682
q2 373 150 139 139
q3 1486 1290 1292 1290
q4 1123 964 955 955
q5 3195 3226 3229 3226
q6 257 130 126 126
q7 1026 518 563 518
q8 2244 2234 2223 2223
q9 6816 6842 6814 6814
q10 3272 3321 3343 3321
q11 333 219 207 207
q12 360 213 211 211
q13 4654 3852 3823 3823
q14 246 206 223 206
q15 595 540 540 540
q16 449 392 396 392
q17 1040 715 623 623
q18 7981 7760 7451 7451
q19 1569 1554 1508 1508
q20 543 346 344 344
q21 3363 2979 2949 2949
q22 372 305 316 305
Total cold run time: 46182 ms
Total hot run time: 41853 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4623 4604 4630 4604
q2 300 175 189 175
q3 3700 3703 3720 3703
q4 2521 2511 2512 2511
q5 6114 6122 6099 6099
q6 242 124 124 124
q7 2594 1956 1934 1934
q8 3730 3710 3693 3693
q9 9403 9374 9380 9374
q10 3991 4122 4096 4096
q11 583 429 471 429
q12 806 627 637 627
q13 4381 3590 3593 3590
q14 271 250 253 250
q15 605 540 532 532
q16 517 455 508 455
q17 2045 2000 1985 1985
q18 9550 8805 9433 8805
q19 1730 1750 1811 1750
q20 2304 1963 1944 1944
q21 7103 6650 6780 6650
q22 672 559 575 559
Total cold run time: 67785 ms
Total hot run time: 63889 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #27013:
URL: https://github.com/apache/doris/pull/27013#issuecomment-1812187477
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27013:
URL: https://github.com/apache/doris/pull/27013#issuecomment-1812380578
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit ccde5826a7a9db5f52e543ee4ab4a3fd52947f0c, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4924 4675 4676 4675
q2 359 158 158 158
q3 2027 1902 1925 1902
q4 1389 1257 1211 1211
q5 3948 3914 3987 3914
q6 249 133 132 132
q7 1403 858 915 858
q8 2724 2752 2737 2737
q9 18437 9608 9584 9584
q10 3466 3533 3509 3509
q11 378 252 237 237
q12 447 282 280 280
q13 4597 3815 3839 3815
q14 313 297 279 279
q15 598 535 522 522
q16 670 591 586 586
q17 1132 959 923 923
q18 7716 7320 7341 7320
q19 1684 1658 1650 1650
q20 572 319 324 319
q21 4355 3934 3983 3934
q22 480 369 372 369
Total cold run time: 61868 ms
Total hot run time: 48914 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4635 4592 4570 4570
q2 343 227 270 227
q3 4007 3988 3952 3952
q4 2695 2684 2687 2684
q5 9480 9507 9535 9507
q6 239 123 127 123
q7 2609 2288 2287 2287
q8 4445 4405 4450 4405
q9 13177 13056 13126 13056
q10 4036 4127 4154 4127
q11 796 654 717 654
q12 976 789 793 789
q13 4330 3555 3573 3555
q14 380 347 345 345
q15 584 528 519 519
q16 749 678 677 677
q17 3877 3859 3871 3859
q18 9531 9162 9009 9009
q19 1777 1763 1752 1752
q20 2420 2065 2045 2045
q21 8697 8786 8504 8504
q22 927 799 802 799
Total cold run time: 80710 ms
Total hot run time: 77445 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
Posted by "gnehil (via GitHub)" <gi...@apache.org>.
gnehil commented on PR #27013:
URL: https://github.com/apache/doris/pull/27013#issuecomment-1833246693
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #27013:
URL: https://github.com/apache/doris/pull/27013#issuecomment-1818319398
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27013:
URL: https://github.com/apache/doris/pull/27013#issuecomment-1833288638
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.52 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17098071122 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
Posted by "gnehil (via GitHub)" <gi...@apache.org>.
gnehil commented on PR #27013:
URL: https://github.com/apache/doris/pull/27013#issuecomment-1839938763
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
Posted by "gnehil (via GitHub)" <gi...@apache.org>.
gnehil commented on PR #27013:
URL: https://github.com/apache/doris/pull/27013#issuecomment-1818321616
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27013:
URL: https://github.com/apache/doris/pull/27013#issuecomment-1833654649
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit b3611f34e07c1fa26178e448cb3b0a9ccee04d5a, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4886 4695 4662 4662
q2 375 199 157 157
q3 1520 1324 1279 1279
q4 1150 993 998 993
q5 3248 3240 3232 3232
q6 253 131 128 128
q7 1011 525 563 525
q8 2238 2249 2256 2249
q9 6984 7228 6941 6941
q10 3289 3810 3400 3400
q11 344 217 208 208
q12 356 224 209 209
q13 4644 3875 3865 3865
q14 249 207 230 207
q15 586 544 519 519
q16 429 378 389 378
q17 1032 685 634 634
q18 8138 7932 8922 7932
q19 1559 1571 1556 1556
q20 578 675 311 311
q21 3417 2960 2986 2960
q22 371 302 308 302
Total cold run time: 46657 ms
Total hot run time: 42647 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4587 4600 4607 4600
q2 327 199 224 199
q3 3767 3782 3765 3765
q4 2527 2503 2515 2503
q5 6206 6192 6206 6192
q6 245 123 122 122
q7 2594 2022 2029 2022
q8 3753 3746 3699 3699
q9 9593 9530 9477 9477
q10 4076 4141 4169 4141
q11 637 519 508 508
q12 791 613 634 613
q13 4380 3631 3633 3631
q14 279 265 253 253
q15 593 524 537 524
q16 534 473 477 473
q17 2095 2046 2085 2046
q18 9469 9054 8922 8922
q19 1789 1792 1794 1792
q20 2309 1980 1985 1980
q21 7246 6953 6870 6870
q22 685 554 566 554
Total cold run time: 68482 ms
Total hot run time: 64886 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba merged PR #27013:
URL: https://github.com/apache/doris/pull/27013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27013:
URL: https://github.com/apache/doris/pull/27013#issuecomment-1812188800
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27013:
URL: https://github.com/apache/doris/pull/27013#issuecomment-1812188907
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schemachange) Fixed the issue of incorrect log information when distribution columns are compared inconsistently [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27013:
URL: https://github.com/apache/doris/pull/27013#issuecomment-1812371721
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.44 seconds
stream load tsv: 567 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17100997589 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org