[GitHub] [druid] rohangarg commented on a change in pull request #11289: Add test for join on __time column

[GitBox <gi...@apache.org>]

rohangarg commented on a change in pull request #11289:
URL: https://github.com/apache/druid/pull/11289#discussion_r638539202



##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -17491,4 +17491,36 @@ public void testEmptyGroupWithOffsetDoesntInfiniteLoop() throws Exception
         ImmutableList.of()
     );
   }
+
+  @Test
+  public void testJoinWithTimeDimension() throws Exception
+  {
+    testQuery(
+        PLANNER_CONFIG_DEFAULT,
+        QUERY_CONTEXT_DONT_SKIP_EMPTY_BUCKETS,

Review comment:
       I was facing some issues while setting up default context earlier, but now when I checked it again the default context works fine too. updated it with default context (using default context explicitly to avoid vectorization path)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org