You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/03/24 11:40:29 UTC

[GitHub] [pulsar] xiaotongwang1 commented on a change in pull request #10012: [issue][improve] add SCRAM-SHA256 support for SASL

xiaotongwang1 commented on a change in pull request #10012:
URL: https://github.com/apache/pulsar/pull/10012#discussion_r600400106



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -305,6 +305,13 @@
     )
     private long topicLoadTimeoutSeconds = 60;
 
+    @FieldContext(
+            category = CATEGORY_SERVER,
+            required = false,
+            doc = "defined your own decryption interface"
+    )
+    private String decryptionInterface;

Review comment:
       It will not do encryotion and decryption by default, and i just make a interface that user can package their decrption implementation jar to pulsar libs dir ,then they can config the password、secret with encryted.
   
   There also exist some sensitive config like OAuth2.0 client_secret、zookeeper SASL DIGEST-MD5 passworld 、TLS keystore password, suggest to be encryted when we use it online 
   
   So i think maybe pulsar can provider a command encryption and decryption method in future , such as a common AES-GCM implementation




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org