[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1860: Spark: Fix resolution of procedures with expressions

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #1860:
URL: https://github.com/apache/iceberg/pull/1860#discussion_r534184147



##########
File path: spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveProcedures.scala
##########
@@ -79,19 +79,7 @@ case class ResolveProcedures(spark: SparkSession) extends Rule[LogicalPlan] with
 
     nameToArgMap.foreach { case (name, arg) =>
       val position = nameToPositionMap(name)
-      val param = params(position)
-      val paramType = param.dataType
-      val argType = arg.expr.dataType

Review comment:
       We cannot call `dataType` as it may not be resolved yet (e.g. calls to functions).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org